Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic custom attributes don't work #78200

Closed
MichalStrehovsky opened this issue Nov 11, 2022 · 2 comments · Fixed by #78297
Closed

Generic custom attributes don't work #78200

MichalStrehovsky opened this issue Nov 11, 2022 · 2 comments · Fixed by #78297
Labels
area-NativeAOT-coreclr
Milestone
7.0.x

Comments

@MichalStrehovsky
Copy link
Member

See blocked test added in #78091.
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Nov 11, 2022
@ghost
Copy link

ghost commented Nov 11, 2022

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

See blocked test added in #78091.

Author: MichalStrehovsky
Assignees: -
Labels:

area-NativeAOT-coreclr
Milestone: -

@MichalStrehovsky MichalStrehovsky added this to the 7.0.x milestone Nov 11, 2022
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Nov 11, 2022
@MichalStrehovsky
Copy link
Member Author

I'm putting this into 7.0. We couldn't even compile generic attributes because S.R.Metadata had a bug that was crashing the compiler until very late in 7.0. We shipped generic attributes with pretty much no testing (#73735). It's pretty dissatisfactory.

MichalStrehovsky added a commit to MichalStrehovsky/runtime that referenced this issue Nov 14, 2022
@MichalStrehovsky
Fix handling generic custom attributes
92580c7 
Fixes dotnet#78200.
@MichalStrehovsky MichalStrehovsky mentioned this issue Nov 14, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Nov 14, 2022
jkotas pushed a commit that referenced this issue Nov 14, 2022
@MichalStrehovsky
Fix handling generic custom attributes (#78297)
1ad1022 
Fixes #78200.
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Nov 14, 2022
github-actions bot pushed a commit that referenced this issue Nov 14, 2022
@MichalStrehovsky
Fix handling generic custom attributes
3678f40 
Fixes #78200.
carlossanlop pushed a commit that referenced this issue Nov 15, 2022
@github-actions @MichalStrehovsky
Fix handling generic custom attributes (#78304)
5d71b4c 
Fixes #78200.

Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
@dotnet dotnet locked as resolved and limited conversation to collaborators Dec 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-NativeAOT-coreclr
Projects
AppModel
Archived in project
Milestone
7.0.x
Development

Successfully merging a pull request may close this issue.

Fix handling generic custom attributes MichalStrehovsky/runtime
1 participant
@MichalStrehovsky