Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling generic custom attributes #78297

Merged
merged 1 commit into from Nov 14, 2022

Conversation

MichalStrehovsky
Copy link
Member

@MichalStrehovsky MichalStrehovsky commented Nov 14, 2022

Fixes #78200.

Cc @dotnet/ilc-contrib

@ghost
Copy link

ghost commented Nov 14, 2022

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #78200.

Author: MichalStrehovsky
Assignees: -
Labels:

area-NativeAOT-coreclr

Milestone: -

@jkotas
Copy link
Member

jkotas commented Nov 14, 2022

Failure is fixed by #78296

@jkotas jkotas merged commit 1ad1022 into dotnet:main Nov 14, 2022
@MichalStrehovsky MichalStrehovsky deleted the genericattr branch November 14, 2022 03:37
@MichalStrehovsky
Copy link
Member Author

/backport to release/7.0

@github-actions
Copy link
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3458321722

@agocke
Copy link
Member

agocke commented Nov 14, 2022

Are we expecting the linked PR to unblock the unit test? Should we port that change back to 7.0 as well?

@MichalStrehovsky
Copy link
Member Author

Are we expecting the linked PR to unblock the unit test? Should we port that change back to 7.0 as well?

TL;DR: the linked pull request could have contributed a useful test for this, but doesn't anymore.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generic custom attributes don't work
3 participants