-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPMI diff failure for SqlSingleTest #84631
Comments
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue DetailsError Blob{
"ErrorMessage": "Assertion failed 'type != TYP_VOID' in 'System.Data.Tests.SqlTypes.SqlSingleTest:Lessers():this' during 'Expand static init'",
"BuildRetry": false,
"ErrorPattern": "",
"ExcludeConsoleLog": false
} Reproduction StepsNo response
|
the assert is fired in |
@jakobbotsch does it ring a bell to you why |
@EgorBo The IR looks invalid, the type of a COMMA should always be the same as its op2. Where do we create that comma? |
@SingleAccretion said it's dead store removal? |
How did this regress, given that JIT PRs run replay/asmdiffs pipelines before checkin? |
@BruceForstall The PR that introduced the "Expand static init" phase (#83911) also changed JIT-EE GUID. The failure is in libraries tests so maybe the PR runs of libraries tests did not manage to expose it (another reason why it's good to trigger libraries-jitstress on large changes). |
But spmi collection process would filter out any failures, so if #83911 introduced the failure but also changed the GUID, I would expect the new collection to hit the assertion during collection, but the collection "clean" process to remove the failing MCs from the resultant MCH. |
Good point. On a closer look the issue actually was introduced with my change in the splitter in #83388 (itself a fix for a different issue I hit as part of that PR)... The last test runs in that PR were from Friday, so before the new phase. |
So this was the result of a couple different passing PRs conflicting post merge? |
Yes, essentially. Well, the bug was in my PR, but apparently stress did not manage to expose it until the extra cases seen with #83911. |
Error Blob
Reproduction Steps
No response
Report
Summary
The text was updated successfully, but these errors were encountered: