-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix gtSplitTree assert #84634
fix gtSplitTree assert #84634
Conversation
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak |
@jakobbotsch can you help me here, I'm a bit confused - the assert is still here or I'm looking at old logs? I was not able to repro it locally after your fix |
The CI logs are showing the latest PR commit: 89d8c9a But SPMI is indeed still raising the assert in the logs as well. |
-- It does look like we change from 10 failures, down to 5 failures A previous PR that failed: https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-84110-merge-3a1827472ef2493689/win-x64/1/console.0e1c6b81.log?helixlogtype=result |
Ah, and this PR covers only lists Where-as the previous lists both a |
Looks like 5 failures still, in libraries_tests.pmi |
The baseline is going to keep failing until we get new rolling builds with both this and #84588. |
Ah right, I didn't notice the failure was only in the baseline here. So, ready to merge then? |
Thanks! I didn't realize it's the baseline so it confused me a lot 🙂 |
I see the a new SPMI is being collected now after Kunal's PR merged today - presumably it will fail because it doesn't have this fix? |
Apply @jakobbotsch's patch