[main] Update dependencies from dotnet/roslyn-analyzers #100520

dotnet-maestro · 2024-04-02T12:32:28Z

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn-analyzers

Subscription: 5465c78f-1281-49a8-f9b0-08d9301a7704
Build: 20240408.3
Date Produced: April 9, 2024 3:50:07 AM UTC
Commit: 7455f63411369a962f769361d1a979a547756ada
Branch: refs/heads/main

Updates:
- Microsoft.CodeAnalysis.Analyzers: from 3.11.0-beta1.24177.1 to 3.11.0-beta1.24208.3
- Microsoft.CodeAnalysis.NetAnalyzers: from 9.0.0-preview.24177.1 to 9.0.0-preview.24208.3

…uild 20240401.2 Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24201.2

…uild 20240402.3 Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24202.3

…uild 20240403.1 Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24203.1

stephentoub · 2024-04-05T11:46:28Z

@MihaZupan, @buyaa-n, the recent SearchValues analyzer changes are causing a crash, eg

error AD0001: Analyzer 'Microsoft.NetCore.CSharp.Analyzers.Performance.CSharpUseSearchValuesAnalyzer' threw an exception of type 'System.ArgumentException' with message 'Syntax node is not within syntax tree'.

MihaZupan · 2024-04-05T12:02:23Z

Scanning through the changes in dotnet/roslyn-analyzers#7252 again nothing immediately stands out to me, I'll try to debug it on runtime locally

It's choking up on this line

runtime/src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs

Line 555 in 7def0b7

    
           int lastIdx = pathNameBytes.LastIndexOfAny(PathInternal.Utf8DirectorySeparators);

…uild 20240403.1 Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24203.1

MihaZupan · 2024-04-05T13:24:40Z

Created dotnet/roslyn-analyzers#7279 that fixes this build, but I don't understand why it's needed (see PR description).

…uild 20240403.1 Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24203.1

…uild 20240408.3 Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24208.3

ericstj · 2024-04-12T17:10:02Z

The one remaining failure from Build Analysis is a build failure:

error : Work item System.Text.RegularExpressions.Tests in job ac703041-e9f2-4478-9a58-f9b8e42fcd95 has failed.

However this is just a cascading error from the test which was already excused with #100715

ericstj · 2024-04-12T17:18:07Z

/ba-g not flipping status of SendToHelix step in build, reluctant to create a known issue as this could be too broad.

* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20240401.2 Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24201.2 * Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20240402.3 Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24202.3 * Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20240403.1 Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24203.1 * Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20240403.1 Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24203.1 * Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20240403.1 Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24203.1 * Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20240403.1 Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24203.1 * Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20240403.1 Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24203.1 * Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20240408.3 Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24208.3 * Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20240408.3 Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24208.3 * Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20240408.3 Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24208.3 * Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20240408.3 Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24208.3 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: Pavel Savara <pavel.savara@gmail.com>

Update dependencies from https://github.com/dotnet/roslyn-analyzers b…

a78fc8b

…uild 20240401.2 Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24201.2

dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Apr 2, 2024

build-analysis bot mentioned this pull request Apr 2, 2024

slow macOS - "##[error]The job running on agent Azure Pipelines 9 ran longer than the maximum time of 60 minutes." dotnet/dnceng#1883

Open

3 tasks

Update dependencies from https://github.com/dotnet/roslyn-analyzers b…

667b38f

…uild 20240402.3 Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24202.3

Update dependencies from https://github.com/dotnet/roslyn-analyzers b…

c206fcd

…uild 20240403.1 Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24203.1

Merge branch 'main' into darc-main-8605e913-c842-4cfb-ace8-84f26c85ed12

117d3d6

Update dependencies from https://github.com/dotnet/roslyn-analyzers b…

ad1e193

…uild 20240403.1 Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24203.1

MihaZupan mentioned this pull request Apr 5, 2024

Check for the CollectionExpression syntax kind early in UseSearchValuesAnalyzer dotnet/roslyn-analyzers#7279

Merged

build-analysis bot mentioned this pull request Apr 5, 2024

[browser] Unable to evaluate script: tab crashed #100275

Closed

Update dependencies from https://github.com/dotnet/roslyn-analyzers b…

f5e73cc

…uild 20240403.1 Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24203.1

build-analysis bot mentioned this pull request Apr 6, 2024

[browser][MT] RuntimeError: memory access out of bounds #96546

Open

Update dependencies from https://github.com/dotnet/roslyn-analyzers b…

2af4d3e

…uild 20240403.1 Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24203.1

build-analysis bot mentioned this pull request Apr 8, 2024

[wasm] Methodical_d2 test failure #100757

Closed

dotnet-maestro bot added 2 commits April 8, 2024 12:21

Update dependencies from https://github.com/dotnet/roslyn-analyzers b…

1cd5d7c

…uild 20240403.1 Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24203.1

Update dependencies from https://github.com/dotnet/roslyn-analyzers b…

1a0c745

…uild 20240408.3 Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24208.3

build-analysis bot mentioned this pull request Apr 9, 2024

System.Text.RegularExpressions.Tests on Mono_Minijit_Debug-Ubuntu #100715

Closed

Update dependencies from https://github.com/dotnet/roslyn-analyzers b…

1879027

…uild 20240408.3 Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24208.3

build-analysis bot mentioned this pull request Apr 10, 2024

CI error on WasmTestOnBrowser-System.Numerics.Tensors.Net8.Tests #97124

Open

Update dependencies from https://github.com/dotnet/roslyn-analyzers b…

00d592a

…uild 20240408.3 Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24208.3

pavelsavara and others added 2 commits April 12, 2024 13:11

Merge branch 'main' into darc-main-8605e913-c842-4cfb-ace8-84f26c85ed12

561426c

Update dependencies from https://github.com/dotnet/roslyn-analyzers b…

a92b808

…uild 20240408.3 Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24208.3

This was referenced Apr 12, 2024

ReadAsStreamAsync_HandlerProducesWellBehavedResponseStream test failure on release coreclr windows x64 Debug CI leg #97259

Closed

[HTTP/3] System.Net.Quic.QuicException: The connection timed out from inactivity #94507

Closed

lewing mentioned this pull request Apr 12, 2024

Timeout in System.Net.Http.Functional.Tests.HttpClientHandlerTest_Http3.ConnectionAttemptCanceled_AuthorityNotBlocked #100971

Closed

ericstj mentioned this pull request Apr 12, 2024

Timeout of ConnectionAttemptCanceled_AuthorityNotBlocked #100972

Closed

ericstj approved these changes Apr 12, 2024

View reviewed changes

ericstj merged commit fd18029 into main Apr 12, 2024
156 of 163 checks passed

dotnet-maestro bot deleted the darc-main-8605e913-c842-4cfb-ace8-84f26c85ed12 branch April 12, 2024 17:22

github-actions bot locked and limited conversation to collaborators May 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[main] Update dependencies from dotnet/roslyn-analyzers #100520

[main] Update dependencies from dotnet/roslyn-analyzers #100520

dotnet-maestro bot commented Apr 2, 2024 •

edited

stephentoub commented Apr 5, 2024 •

edited

MihaZupan commented Apr 5, 2024 •

edited

MihaZupan commented Apr 5, 2024

ericstj commented Apr 12, 2024 •

edited

ericstj commented Apr 12, 2024

[main] Update dependencies from dotnet/roslyn-analyzers #100520

[main] Update dependencies from dotnet/roslyn-analyzers #100520

Conversation

dotnet-maestro bot commented Apr 2, 2024 • edited

From https://github.com/dotnet/roslyn-analyzers

stephentoub commented Apr 5, 2024 • edited

MihaZupan commented Apr 5, 2024 • edited

MihaZupan commented Apr 5, 2024

ericstj commented Apr 12, 2024 • edited

ericstj commented Apr 12, 2024

dotnet-maestro bot commented Apr 2, 2024 •

edited

stephentoub commented Apr 5, 2024 •

edited

MihaZupan commented Apr 5, 2024 •

edited

ericstj commented Apr 12, 2024 •

edited