-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some TODO #5213 comments #100954
Add some TODO #5213 comments #100954
Conversation
Tagging subscribers to this area: @dotnet/area-system-numerics |
@@ -1405,6 +1405,7 @@ internal void GetDate(out int year, out int month, out int day) | |||
[MethodImpl(MethodImplOptions.AggressiveInlining)] | |||
internal void GetTime(out int hour, out int minute, out int second) | |||
{ | |||
// TODO: https://github.com/dotnet/runtime/issues/5213 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd honestly prefer these to instead just switch to using ulong.DivRem
, that should produce the same code today and will automatically be updated in the future when any JIT optimization gets added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I switched to DivRem except for in Decimal.DecCalc, where we the TODOs in this PR and the ones that already exists are heterogenous.
… into todo-5213-comments
… into todo-5213-comments
Added TODO comments referencing #5213 where we should replace remainder calulcation using modulus operator after said issue is resolved