Add some TODO #5213 comments #100954
Closed
Add some TODO #5213 comments #100954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-numerics |
dotnet-policy-service
bot
added
the
community-contribution
lilinus
changed the title
This was referenced Apr 12, 2024
System.Net.Http.Functional.Tests.HttpMetricsTest_Http11_Async_HttpMessageInvoker Test failure
#96407
Closed
This was referenced Apr 16, 2024
| @@ -1405,6 +1405,7 @@ internal void GetDate(out int year, out int month, out int day) | |||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | |||
| internal void GetTime(out int hour, out int minute, out int second) | |||
| { | |||
| // TODO: https://github.com/dotnet/runtime/issues/5213 | |||
There was a problem hiding this comment.
I'd honestly prefer these to instead just switch to using ulong.DivRem, that should produce the same code today and will automatically be updated in the future when any JIT optimization gets added.
There was a problem hiding this comment.
I switched to DivRem except for in Decimal.DecCalc, where we the TODOs in this PR and the ones that already exists are heterogenous.
… into todo-5213-comments
… into todo-5213-comments
This was referenced Apr 26, 2024
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added TODO comments referencing #5213 where we should replace remainder calulcation using modulus operator after said issue is resolved