-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create ReadOnlySpan marshaller for ManagedToUnmanagedOut scenarios #101095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note regarding the
|
This was referenced Apr 16, 2024
This will need an API proposal as it does introduce new public API. Can you make an issue for that/update the issue that this is fixing? |
API proposal: #101136 |
This was referenced Apr 16, 2024
…ySpanMarshaller
@dotnet/interop-contrib API got approved, please take a look when you have a chance. |
jkoritzinsky
previously approved these changes
Jun 11, 2024
...tem.Private.CoreLib/src/System/Runtime/InteropServices/Marshalling/ReadOnlySpanMarshaller.cs
Outdated
Show resolved
Hide resolved
jkoritzinsky
approved these changes
Jun 11, 2024
AaronRobinsonMSFT
approved these changes
Jun 11, 2024
elinor-fung
approved these changes
Jun 12, 2024
...braries/System.Runtime.InteropServices/tests/LibraryImportGenerator.Tests/CollectionTests.cs
Outdated
Show resolved
Hide resolved
This was referenced Jun 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new marshaller for
ReadOnlySpan
to marshal inManagedToUnmanagedOut
scenarios to enable returning aReadOnlySpan
from aLibraryImport
method.Fixes #96525