Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create ReadOnlySpan marshaller for ManagedToUnmanagedOut scenarios #101095

Merged
merged 5 commits into from
Jun 17, 2024
Merged

Create ReadOnlySpan marshaller for ManagedToUnmanagedOut scenarios #101095

merged 5 commits into from
Jun 17, 2024

Conversation

jtschuster
Copy link
Member

@jtschuster jtschuster commented Apr 15, 2024 •
edited

Adds a new marshaller for ReadOnlySpan to marshal in ManagedToUnmanagedOut scenarios to enable returning a ReadOnlySpan from a LibraryImport method.

Fixes #96525

@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

This was referenced Apr 16, 2024
Closed
Closed
Closed
Closed
Closed
@jtschuster jtschuster marked this pull request as ready for review April 16, 2024 17:11
@jkoritzinsky
Copy link
Member

This will need an API proposal as it does introduce new public API. Can you make an issue for that/update the issue that this is fixing?

@jtschuster
Copy link
Member Author

API proposal: #101136

This was referenced Apr 16, 2024
Closed
Closed
Closed
@jtschuster
Copy link
Member Author

@dotnet/interop-contrib API got approved, please take a look when you have a chance.

jkoritzinsky
jkoritzinsky previously approved these changes Jun 11, 2024
View reviewed changes
@jkoritzinsky jkoritzinsky dismissed their stale review June 11, 2024 20:39

Missed an important change

@build-analysis build-analysis bot mentioned this pull request Jun 12, 2024
Closed
This was referenced Jun 12, 2024
Closed
Open
Closed
This was referenced Jun 13, 2024
Open
Open
Closed
@jtschuster jtschuster merged commit 7ffbd12 into dotnet:main Jun 17, 2024
154 of 156 checks passed
@jtschuster jtschuster mentioned this pull request Jun 17, 2024
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

@elinor-fung elinor-fung elinor-fung approved these changes

Assignees

@jtschuster jtschuster

Labels
area-System.Runtime.InteropServices new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Returning a ReadOnlySpan<byte> from a LibraryImport fails
4 participants
@jtschuster @jkoritzinsky @AaronRobinsonMSFT @elinor-fung