-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Add optimization flags to bitcode compilation #101538
Changes from all commits
df13e5b
85be7b4
3dcc8ac
1ea9dcb
7d7117f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,6 +44,8 @@ | |
|
||
- $(EmccLinkOptimizationFlag) - Optimization flag to use for the link step | ||
- $(EmccCompileOptimizationFlag) - Optimization flag to use for compiling native files | ||
- $(WasmBitcodeCompileOptimizationFlag) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If we end up having a separate There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The other wasi specific properties are not listed here either. I guess we consider it rapidly moving target? |
||
- Optimization flag to use for compiling bitcode files | ||
|
||
- $(EmccFlags) - Emcc flags used for both compiling native files, and linking | ||
- $(EmccExtraLDFlags) - Extra emcc flags for linking | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want a separate property for WASI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have other wasi specific flags here too, like
WasiClangLinkOptimizationFlag
, so I kept it separate as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
WasiClangLinkOptimizationFlag
is specific thing for WASI. This one is a shared concept from my POV