Switch from arm64 biarch image to Azure Linux image #101946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
needs-area-label
|
/azp run runtime-extra-platforms-other |
|
No pipelines are associated with this pull request. |
|
/azp run runtime-llvm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced May 6, 2024
kotlarmilos
approved these changes
May 7, 2024
|
It doesn't have GNU binutils - but it has LLVM equivalents. |
|
This is the difference in container size (uncompressed). Almost 1GB. $ docker images mcr.microsoft.com/dotnet-buildtools/prereqs:cbl-mariner-2.0-cross-biarch-amd64-arm64
REPOSITORY TAG IMAGE ID CREATED SIZE
mcr.microsoft.com/dotnet-buildtools/prereqs cbl-mariner-2.0-cross-biarch-amd64-arm64 ef26c9c48521 12 hours ago 5.81GB
$ docker images mcr.microsoft.com/dotnet-buildtools/prereqs:azurelinux-3.0-cross-arm64-net9.0
REPOSITORY TAG IMAGE ID CREATED SIZE
mcr.microsoft.com/dotnet-buildtools/prereqs azurelinux-3.0-cross-arm64-net9.0 a4e65664d770 10 hours ago 4.97GB |
michaelgsharp
pushed a commit
to michaelgsharp/runtime
that referenced
this pull request
May 9, 2024
The biarch image is currently unused in our ci builds. Use of the biarch image was added in dotnet#91019 but the job that used it was disabled for arm64 in dotnet#92057. dotnet#90427 tracks adding back the arm64 jobs. The arm64 fullaot job was added in dotnet#55362 which explains: > We don't ship any products using FullAOT on Linux x64/arm64, but this compilation mode is used for iOS, FullAOT-related issues that affect iOS are likely to be caught by FullAOT on Linux x64/arm64, and it is a lot easier to build, develop, and debug on desktop OSes. If the arm64 job is enabled again in the future, it should be made to use a new entry in `pipeline-with-resources.yml`, instead of modifying the image used for all other linux_arm64 jobs. Fixes dotnet#101707
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
The biarch image is currently unused in our ci builds. Use of the biarch image was added in dotnet#91019 but the job that used it was disabled for arm64 in dotnet#92057. dotnet#90427 tracks adding back the arm64 jobs. The arm64 fullaot job was added in dotnet#55362 which explains: > We don't ship any products using FullAOT on Linux x64/arm64, but this compilation mode is used for iOS, FullAOT-related issues that affect iOS are likely to be caught by FullAOT on Linux x64/arm64, and it is a lot easier to build, develop, and debug on desktop OSes. If the arm64 job is enabled again in the future, it should be made to use a new entry in `pipeline-with-resources.yml`, instead of modifying the image used for all other linux_arm64 jobs. Fixes dotnet#101707
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't find a ci leg where the biarch image is still needed, so trying to remove it.
Use of the biarch image was added in #91019 but the job that used it was disabled for arm64 in #92057. #90427 tracks adding back the arm64 jobs.
From what I could gather, the arm64 fullaot job was added in #55362 which explains:
If the arm64 job is enabled again in the future, it should probably be made to use a new entry in
pipeline-with-resources.yml, instead of modifying the image used for all other linux_arm64 jobs.Fixes #101707