Update ARM64 LLVM AOT runtime builds to use the generic libclang.so file #102175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ile as the new image does not have libclang.so.16, it has libclang.so and libclang.so.18 instead.
LoopedBard3
requested review from
sblom,
DrewScoggins,
matouskozak and
caaavik-msft
|
Tagging subscribers to this area: @directhex |
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
|
Tagging subscribers to this area: @directhex |
caaavik-msft
approved these changes
May 13, 2024
akoeplinger
approved these changes
May 14, 2024
matouskozak
approved these changes
May 14, 2024
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
…ile as the new image does not have libclang.so.16, it has libclang.so and libclang.so.18 instead. (dotnet#102175)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new container updated in #101946 that is used when building the Linux Arm64 AOT LLVM Mono artifacts (perf_slow) does not have libclang.so.16, instead having libclang.so.18.1. This updates builds to use the generic libclang.so next to the libclang.so.18.1 file to fix this and help future proof.
Test run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2450460&view=results