Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable tests failing on NAOT #102065

Merged
merged 3 commits into from
May 12, 2024
Merged

Disable tests failing on NAOT #102065

merged 3 commits into from
May 12, 2024

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented May 10, 2024

No description provided.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 10, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@jkotas
Copy link
Member Author

jkotas commented May 10, 2024

Follow up on #101317. cc @jkoritzinsky

@jkotas
Copy link
Member Author

jkotas commented May 10, 2024

/azp run runtime-nativeaot-outerloop

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkotas
Copy link
Member Author

jkotas commented May 10, 2024

@jkoritzinsky I am getting the following error:

Generator 'XUnitWrapperGenerator' failed to generate source. It will not contribute to the output and compilation errors may occur as a result. Exception was of type 'NullReferenceException' with message 'Object reference not set to an instance of an object.'

It seems to be caused by https://github.com/dotnet/runtime/pull/102065/files#diff-eb5ac758f23f3275cf69654218fd507c2fc49cb552c1885417c202da5fa18872R133 . Are ActiveIssue attributes in IL tests expected to work?

@jkoritzinsky
Copy link
Member

Yes, they should work as long as Roslyn can parse them and get a matching constructor.

@jkotas
Copy link
Member Author

jkotas commented May 11, 2024

/azp run runtime-nativeaot-outerloop

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkotas
Copy link
Member Author

jkotas commented May 11, 2024

The remaining failures are infra issues

@dotnet dotnet deleted a comment from azure-pipelines bot May 11, 2024
@jkotas jkotas merged commit 3de068c into dotnet:main May 12, 2024
87 of 90 checks passed
tannergooding
tannergooding reviewed May 12, 2024
View reviewed changes
src/tests/JIT/Methodical/doublearray/dblarray4.cs
@@ -22,6 +22,7 @@ public class DblArray4
[Fact]
[SkipOnCoreClr("This test is not compatible with GCStress.", RuntimeTestModes.AnyGCStress)]
[OuterLoop]
[ActiveIssue("https://github.com/dotnet/runtime/issues/101284", typeof(TestLibrary.Utilities), nameof(TestLibrary.Utilities.IsNativeAot))]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is failing in some outerloop jobs with

src/tests/JIT/Methodical/doublearray/dblarray4.cs(25,76): error CS0246: The type or namespace name 'TestLibrary' could not be found (are you missing a using directive or an assembly reference?) [/__w/1/s/src/tests/JIT/Methodical/doublearray/dblarray4_cs_d.csproj]

For example, from https://dev.azure.com/dnceng-public/public/_build/results?buildId=673058&view=logs&jobId=3725811e-4a8b-5f6a-b03b-a353ee894148&j=3725811e-4a8b-5f6a-b03b-a353ee894148&t=d59fccfb-2b13-5841-75bf-bfec705ee16a

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#102134

@jkotas jkotas deleted the naot-tests branch May 12, 2024 16:18
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
@jkotas @Ruihan-Yin
Disable tests failing on NAOT (dotnet#102065)
e47e1d6
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tannergooding tannergooding tannergooding left review comments

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

@filipnavara filipnavara filipnavara approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky

Assignees

@jkotas jkotas

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jkotas @jkoritzinsky @filipnavara @tannergooding