Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable tests failing on NAOT #102065

Merged
merged 3 commits into from
May 12, 2024
Merged

Disable tests failing on NAOT #102065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f76d334
Disable tests failing on NAOT
jkotas May 10, 2024
31dc922
Try to fix build
jkotas May 11, 2024
b279525
Merge branch 'main' into naot-tests
jkotas May 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/tests/JIT/Methodical/doublearray/dblarray1.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ public static void Run(Action f)
[Fact]
[SkipOnCoreClr("This test is not compatible with GCStress.", RuntimeTestModes.AnyGCStress)]
[OuterLoop]
[ActiveIssue("https://github.com/dotnet/runtime/issues/101284", typeof(TestLibrary.Utilities), nameof(TestLibrary.Utilities.IsNativeAot))]
public static int TestEntryPoint()
{
if (RuntimeInformation.ProcessArchitecture == Architecture.X86)
Expand Down
1 change: 1 addition & 0 deletions src/tests/JIT/Methodical/doublearray/dblarray2.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,7 @@ public static void Run(Action f)
[Fact]
[SkipOnCoreClr("This test is not compatible with GCStress.", RuntimeTestModes.AnyGCStress)]
[SkipOnMono("Needs triage")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/101284", typeof(TestLibrary.Utilities), nameof(TestLibrary.Utilities.IsNativeAot))]
public static int TestEntryPoint()
{
if (RuntimeInformation.ProcessArchitecture == Architecture.X86)
Expand Down
1 change: 1 addition & 0 deletions src/tests/JIT/Methodical/doublearray/dblarray3.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ public static void Run(Action f)
[SkipOnCoreClr("This test is not compatible with GCStress.", RuntimeTestModes.AnyGCStress)]
[SkipOnMono("Needs triage")]
[OuterLoop]
[ActiveIssue("https://github.com/dotnet/runtime/issues/101284", typeof(TestLibrary.Utilities), nameof(TestLibrary.Utilities.IsNativeAot))]
public static int TestEntryPoint()
{
Console.WriteLine(RuntimeInformation.ProcessArchitecture);
Expand Down
1 change: 1 addition & 0 deletions src/tests/JIT/Methodical/doublearray/dblarray4.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ public class DblArray4
[Fact]
[SkipOnCoreClr("This test is not compatible with GCStress.", RuntimeTestModes.AnyGCStress)]
[OuterLoop]
[ActiveIssue("https://github.com/dotnet/runtime/issues/101284", typeof(TestLibrary.Utilities), nameof(TestLibrary.Utilities.IsNativeAot))]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is failing in some outerloop jobs with

src/tests/JIT/Methodical/doublearray/dblarray4.cs(25,76): error CS0246: The type or namespace name 'TestLibrary' could not be found (are you missing a using directive or an assembly reference?) [/__w/1/s/src/tests/JIT/Methodical/doublearray/dblarray4_cs_d.csproj]

For example, from https://dev.azure.com/dnceng-public/public/_build/results?buildId=673058&view=logs&jobId=3725811e-4a8b-5f6a-b03b-a353ee894148&j=3725811e-4a8b-5f6a-b03b-a353ee894148&t=d59fccfb-2b13-5841-75bf-bfec705ee16a

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#102134

public static int TestEntryPoint()
{
if (RuntimeInformation.ProcessArchitecture == Architecture.X86)
Expand Down
1 change: 0 additions & 1 deletion src/tests/JIT/Methodical/refany/array2.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ private static void TestRef(TypedReference _ref)

[Fact]
[OuterLoop]
[ActiveIssue("https://github.com/dotnet/runtimelab/issues/155", typeof(PlatformDetection), nameof(PlatformDetection.IsNonZeroLowerBoundArrayNotSupported))]
public static int TestEntryPoint()
{
ulong[,] aul2 = new ulong[,] { { 1, 2, 3 }, { 4, 5, 6 } };
Expand Down
19 changes: 19 additions & 0 deletions src/tests/JIT/Methodical/refany/array2.il
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,13 @@
.publickeytoken = (B0 3F 5F 7F 11 D5 0A 3A )
.ver 4:0:0:0
}
.assembly extern System.Runtime { .publickeytoken = (B0 3F 5F 7F 11 D5 0A 3A ) }
.assembly ASSEMBLY_NAME
{
}
.assembly extern xunit.core {}
.assembly extern Microsoft.DotNet.XUnitExtensions { .publickeytoken = (31 BF 38 56 AD 36 4E 35 ) }
.assembly extern TestLibrary {}
// MVID: {1781A471-82F3-4159-8D0F-B3B5A9FF1BB6}
.namespace JitTest_array2_refany_il
{
Expand Down Expand Up @@ -125,6 +128,22 @@
.custom instance void [xunit.core]Xunit.FactAttribute::.ctor() = (
01 00 00 00
)
// [ActiveIssue("https://github.com/dotnet/runtimelab/issues/155", typeof(PlatformDetection), nameof(PlatformDetection.IsNonZeroLowerBoundArrayNotSupported))]
.custom instance void [Microsoft.DotNet.XUnitExtensions]Xunit.ActiveIssueAttribute::.ctor(string,
class [System.Runtime]System.Type,
string[]) = ( 01 00 2F 68 74 74 70 73 3A 2F 2F 67 69 74 68 75
62 2E 63 6F 6D 2F 64 6F 74 6E 65 74 2F 72 75 6E
74 69 6D 65 6C 61 62 2F 69 73 73 75 65 73 2F 31
35 35 61 54 65 73 74 4C 69 62 72 61 72 79 2E 50
6C 61 74 66 6F 72 6D 44 65 74 65 63 74 69 6F 6E
2C 20 54 65 73 74 4C 69 62 72 61 72 79 2C 20 56
65 72 73 69 6F 6E 3D 30 2E 30 2E 30 2E 30 2C 20
43 75 6C 74 75 72 65 3D 6E 65 75 74 72 61 6C 2C
20 50 75 62 6C 69 63 4B 65 79 54 6F 6B 65 6E 3D
6E 75 6C 6C 01 00 00 00 24 49 73 4E 6F 6E 5A 65
72 6F 4C 6F 77 65 72 42 6F 75 6E 64 41 72 72 61
79 4E 6F 74 53 75 70 70 6F 72 74 65 64 00 00 )

.entrypoint
// Code size 150 (0x96)
.maxstack 4
Expand Down
15 changes: 0 additions & 15 deletions src/tests/issues.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1152,21 +1152,6 @@

<!-- NativeAOT x86 specific -->
<ItemGroup Condition="'$(XunitTestBinBase)' != '' and '$(TestBuildMode)' == 'nativeaot' and '$(RuntimeFlavor)' == 'coreclr' and '$(TargetArchitecture)' == 'x86'">
<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical/doublearray/dblarray2_cs_d/**">
<Issue>https://github.com/dotnet/runtime/issues/101284</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical/doublearray/dblarray2_cs_do/**">
<Issue>https://github.com/dotnet/runtime/issues/101284</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical/doublearray/dblarray2_cs_r/**">
<Issue>https://github.com/dotnet/runtime/issues/101284</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical/doublearray/dblarray2_cs_ro/**">
<Issue>https://github.com/dotnet/runtime/issues/101284</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical/doublearray/dblarray3_cs_do/**">
<Issue>https://github.com/dotnet/runtime/issues/101284</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/JIT/opt/perf/doublealign/Arrays/**">
<Issue>https://github.com/dotnet/runtime/issues/101284</Issue>
</ExcludeList>
Expand Down
Loading