Modify error message for failed RW mappings #102458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @mangod9 |
|
@ayende, @loop-evgeny, does the modified message sound sufficient to you? |
|
I would mention the configuration item explicitly, or add a specific term that you can search by it. |
ayende
reviewed
May 20, 2024
| @@ -905,7 +905,7 @@ void* ExecutableAllocator::MapRW(void* pRX, size_t size, CacheableMapping cacheM | |||
|
|
|||
| if (pRW == NULL) | |||
| { | |||
| g_fatalErrorHandler(COR_E_EXECUTIONENGINE, W("Failed to create RW mapping for RX memory")); | |||
| g_fatalErrorHandler(COR_E_EXECUTIONENGINE, W("Failed to create RW mapping for RX memory. This can be caused by not enough memory or by exceeding the configured maximum number of memory mappings.")); | |||
There was a problem hiding this comment.
Suggested change
| g_fatalErrorHandler(COR_E_EXECUTIONENGINE, W("Failed to create RW mapping for RX memory. This can be caused by not enough memory or by exceeding the configured maximum number of memory mappings.")); | |
| g_fatalErrorHandler(COR_E_EXECUTIONENGINE, W("Failed to create RW mapping for RX memory. This can cause by insufficient memory or hitting the limit of memory mapping on Unix (vm.map_max_count).")); |
Suggested change
| g_fatalErrorHandler(COR_E_EXECUTIONENGINE, W("Failed to create RW mapping for RX memory. This can be caused by not enough memory or by exceeding the configured maximum number of memory mappings.")); | |
| g_fatalErrorHandler(COR_E_EXECUTIONENGINE, W("Failed to create RW mapping for RX memory. This can be caused by not enough memory or by exceeding the configured maximum number of memory mappings.")); |
There was a problem hiding this comment.
Ok, sounds good. I'll just change "Unix" to "Linux", as that setting is Linux specific.
|
I like ayende's wording! |
The executable allocator can fail to create a RW mapping for an existing RX mapping due to both being out of memory and exceeding maximum number of memory mappings. People were getting confused by the original error message. This chnage updates it to explicitly mention the cases when it can occur.
janvorli
force-pushed
the
update-mapping-error-message
branch
from
12289ff
to
b8bd95d
Compare
steveharter
pushed a commit
to steveharter/runtime
that referenced
this pull request
May 28, 2024
The executable allocator can fail to create a RW mapping for an existing RX mapping due to both being out of memory and exceeding maximum number of memory mappings. People were getting confused by the original error message. This chnage updates it to explicitly mention the cases when it can occur.
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
The executable allocator can fail to create a RW mapping for an existing RX mapping due to both being out of memory and exceeding maximum number of memory mappings. People were getting confused by the original error message. This chnage updates it to explicitly mention the cases when it can occur.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The executable allocator can fail to create a RW mapping for an existing RX mapping due to both being out of memory and exceeding maximum number of memory mappings. People were getting confused by the original error message.
This change updates it to explicitly mention the cases when it can occur.