Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to zlib-ng, part 1: copy source code only #102520

Merged
merged 4 commits into from
May 22, 2024

Conversation

carlossanlop
Copy link
Member

@carlossanlop carlossanlop commented May 21, 2024

Contributes to #101465

As requested in the original PR, to make reviewing easier, I am submitting this separate PR that copies the zlib-ng source code and updates the licensing files, but without consuming it in runtime yet.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-io-compression
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as all changes to zlib-ng are captured in zlib-ng-version.txt.

@carlossanlop
Copy link
Member Author

@jkotas I have a question about your comment in the other PR:

The test binaries like src/native/external/zlib-ng/test/CVE-2002-0059/test.gz are going to pain to deal with for source build.

Can we exclude the test subdirectory from the vendored copy? I do not expect that we are going to run the native zlib-ng tests in this repo.

For my own education, why would this cause problems?

@jkoritzinsky
Copy link
Member

Source-build has issues with introducing binary files into the repo. There's a whole process that needs to be done to make sure that they're not introduced into the final product in any way (including having the source-build build itself remove the files from disk before starting). It's easier if we don't have the binaries in the first place.

@carlossanlop carlossanlop merged commit 6e43b6a into dotnet:main May 22, 2024
147 of 149 checks passed
@carlossanlop carlossanlop deleted the zlib-ng-onlyadd branch May 22, 2024 18:50
steveharter pushed a commit to steveharter/runtime that referenced this pull request May 28, 2024
* Bring in the zlib-ng source code into the repo but without plugging it in yet.
* Include the required zlib-ng license and version changes.
* Remove the zlib-ng/doc/ and zlib-ng/tests/ folders and mention this in the newly added zlib-ng-version.txt file.
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
* Bring in the zlib-ng source code into the repo but without plugging it in yet.
* Include the required zlib-ng license and version changes.
* Remove the zlib-ng/doc/ and zlib-ng/tests/ folders and mention this in the newly added zlib-ng-version.txt file.
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants