-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user_events support for the native runtime events #102523
Conversation
src/coreclr/vm/eventing/userevents/LinuxTracepoints/.gitattributes
Outdated
Show resolved
Hide resolved
I believe all the build issues are sorted now, and the LinuxTracepoints code is moved to the appropriate place (src/native/external) so marking this as ready to review. @noahfalk @brianrob if you could take a look I would appreciate it. Since the generated files aren't part of the code review I will paste examples here.
Each provider has a separate file, following the custom of EventPipe. The files declare the provider and then add a
|
@@ -0,0 +1,53 @@ | |||
include(FindPython) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jkoritzinsky Any concerns with the CMake here?
Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small comments/questions inline, but the main request I'd have is please add at least a brief document in docs/design/features :)
It should describe what functionality is being added, how to turn it on, what is the format of the data in the events, the current state of the feature (ie no EventSource support, no TraceEvent support), what Linux environment is needed for it to work, and a pointer to relevant code/docs/important comments for those wanting to learn more.
Can you add those examples in the design doc and/or as comments in the python code. They are very useful to understand the feature not just now but when someone is trying to learn about it in the future. |
Co-authored-by: Noah Falk <noahfalk@users.noreply.github.com>
Sure thing, just pushed a design doc and some more comments in genUserEvents.py |
@noahfalk I just pushed a new commit that makes it so user_events can be checked by category, not just event. Can you take a look and make sure you're ok with the additional changes? |
Opening as a draft because there are still build errors, but I wanted to give people a chance to look at the shape of the changes. This adds support to the runtime to emit events under the user_events format, using the EventHeader format described at https://github.com/microsoft/LinuxTracepoints/.