Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call gtFoldExpr after fgMorphExpandInstanceField #103648

Merged
merged 4 commits into from
Jun 19, 2024

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Jun 18, 2024

Fixes #103577

it's a pretty annoying assert that we should probably just delete - gtMarkAddrMode may hit that assert when it encounters cns + cns like foldable trees in tier0 (with opts) or tier1, because it does its own foldings and after that runs some validations

fgMorphExpandInstanceField may return:

[000023] -----------                         *  ADD       long
[000003] H----------                         +--*  CNS_INT(h) long   0x1c880109658 static Fseq[foo]
[000022] -----------                         \--*  CNS_INT   long   4

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 18, 2024
@EgorBo
Copy link
Member Author

EgorBo commented Jun 18, 2024

/azp run runtime-coreclr jitstress

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@EgorBo EgorBo marked this pull request as ready for review June 19, 2024 11:57
@EgorBo EgorBo requested a review from jakobbotsch June 19, 2024 11:57
@EgorBo
Copy link
Member Author

EgorBo commented Jun 19, 2024

PTAL @jakobbotsch @dotnet/jit-contrib quick fix for an assert to unblock jitstress

@EgorBo EgorBo merged commit 9c51d32 into dotnet:main Jun 19, 2024
107 checks passed
@EgorBo EgorBo deleted the fold-fld-import branch June 19, 2024 12:39
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
2 participants