Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move runtime-deps CentOS Stream 8 package to CentOS Stream 9. #103708

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

jkoritzinsky
Copy link
Member

Fixes #102344

@jkoritzinsky jkoritzinsky added breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. area-Setup labels Jun 19, 2024
Copy link
Contributor

Added needs-breaking-change-doc-created label because this PR has the breaking-change label.

When you commit this breaking change:

  1. Create and link to this PR and the issue a matching issue in the dotnet/docs repo using the breaking change documentation template, then remove this needs-breaking-change-doc-created label.
  2. Ask a committer to mail the .NET Breaking Change Notification DL.

Tagging @dotnet/compat for awareness of the breaking change.

@dotnet-policy-service dotnet-policy-service bot added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Jun 19, 2024
@jkoritzinsky
Copy link
Member Author

This is part of our supported-OS update, so a separate breaking change notice is not necessary.

@jkoritzinsky jkoritzinsky removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Jun 19, 2024
@@ -11,7 +11,7 @@

<ItemGroup Condition="'$(BuildRpmPackage)' == 'true'">
<InstallerProjectReference Include="installers/dotnet-runtime-deps/dotnet-runtime-deps-azl.3.proj" />
<InstallerProjectReference Include="installers/dotnet-runtime-deps/dotnet-runtime-deps-centos.8.proj" />
<InstallerProjectReference Include="installers/dotnet-runtime-deps/dotnet-runtime-deps-centos.9.proj" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume there's no need to build centos-8 deps package anymore, is that correct?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only consumer of the deps package are our other packages, so we don't need the centos-8 deps package any more.

@jkoritzinsky jkoritzinsky merged commit 6d838df into dotnet:main Jun 19, 2024
68 of 70 checks passed
@jkoritzinsky jkoritzinsky deleted the centos9 branch June 19, 2024 20:51
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Setup breaking-change Issue or PR that represents a breaking API or functional change over a prerelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing centos-stream9 runtime assets
3 participants