Address more issue numbers in the code

src/coreclr/src/tools/crossgen2/ILCompiler.Reflection.ReadyToRun/ReadyToRunReader.cs

@@ -420,7 +420,7 @@ public bool InputArchitectureSupported()
 
         // TODO: Fix R2RDump issue where an R2R image cannot be dissassembled with the x86 CoreDisTools
         // For the short term, we want to error out with a decent message explaining the unexpected error
-        // Issue #19564: https://github.com/dotnet/coreclr/issues/19564
+        // Issue https://github.com/dotnet/coreclr/issues/19564
         public bool DisassemblerArchitectureSupported()
         {
             System.Runtime.InteropServices.Architecture val = System.Runtime.InteropServices.RuntimeInformation.ProcessArchitecture;

src/coreclr/tests/src/JIT/Directed/StructPromote/Unsafe/AccessInvalidFieldOffset.cs

@@ -2,7 +2,8 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-// The test came from #20085. It tries to access field from a promoted struct with an offset that 
+// The test came from https://github.com/dotnet/corefx/issues/20085.
+// It tries to access field from a promoted struct with an offset that 
 // is not valid for the promoted struct type.
 
 using System.Runtime.CompilerServices;

src/coreclr/tests/src/JIT/Directed/StructPromote/Unsafe/ReadDoubleFromIntOffset.cs

@@ -2,7 +2,8 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-// The test came from #20085. It tests that we do access overlapping fields with the correct types. 
+// The test came from https://github.com/dotnet/corefx/issues/20085.
+// It tests that we do access overlapping fields with the correct types. 
 // Espessialy if the stuct was casted by 'Unsafe.As` from a promoted type
 // and the promoted type had another field on the same offset but with a different type/size.
 

src/coreclr/tests/src/JIT/Directed/StructPromote/Unsafe/ReadStructAsAnotherType.cs

@@ -2,7 +2,8 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-// The test came from #20085. It tests that we do access overlapping fields with the correct types. 
+// The test came from https://github.com/dotnet/corefx/issues/20085.
+// It tests that we do access overlapping fields with the correct types. 
 // Espessialy if the stuct was casted by 'Unsafe.As` from a promoted type
 // and the promoted type had another field on the same offset but with a different type/size.
 

src/coreclr/tests/src/JIT/Methodical/structs/systemvbringup/structpinvoketests.cs

@@ -171,7 +171,7 @@ public struct S20
             public long z;
             public long w;
         }
-/* These tests are not working on non Windows CoreCLR. Enable this when GH Issue #2076 is resolved.
+/* These tests are not working on non Windows CoreCLR. Enable this when https://github.com/dotnet/coreclr/issues/2076 is resolved.
         [StructLayout(LayoutKind.Sequential)]
         public struct S28
         {
@@ -185,7 +185,7 @@ public struct S29
             public int x;
             public object y;
         }
- Enable this when GH Issue #2076 is resolved. */
+ Enable this when https://github.com/dotnet/coreclr/issues/2076 is resolved. */
         public struct S30
         {
             public long x;
@@ -213,10 +213,10 @@ public struct S30
         public delegate void MyCallback19(S19 s);
         public delegate void MyCallback20(S20 s);
 
-/* These tests are not working on non Windows CoreCLR.  Enable this when GH Issue #2076 is resolved.
+/* These tests are not working on non Windows CoreCLR.  Enable this when https://github.com/dotnet/coreclr/issues/2076 is resolved.
         public delegate void MyCallback28(S28 s);
         public delegate void MyCallback29(S29 s);
- Enable this when GH Issue #2076 is resolved. */
+ Enable this when https://github.com/dotnet/coreclr/issues/2076 is resolved. */
         public delegate void MyCallback30(S30 s1, S30 s2, S30 s3);
 
         [DllImport("jitstructtests_lib")]
@@ -278,14 +278,14 @@ Enable this when GH Issue #2076 is resolved. */
 
         [DllImport("jitstructtests_lib")]
         public static extern void InvokeCallback20(MyCallback20 callback, S20 s);
-/* These tests are not working on non Windows CoreCLR.  Enable this when GH Issue #2076 is resolved.
+/* These tests are not working on non Windows CoreCLR.  Enable this when https://github.com/dotnet/coreclr/issues/2076 is resolved.
         
         [DllImport("jitstructtests_lib")]
         public static extern void InvokeCallback28(MyCallback28 callback, S28 s);
 
         [DllImport("jitstructtests_lib")]
         public static extern void InvokeCallback29(MyCallback29 callback, S29 s);
- Enable this when GH Issue #2076 is resolved. */
+ Enable this when https://github.com/dotnet/coreclr/issues/2076 is resolved. */
         [DllImport("jitstructtests_lib")]
         public static extern void InvokeCallback30(MyCallback30 callback, S30 s1, S30 s2, S30 s3);
 
@@ -348,14 +348,14 @@ Enable this when GH Issue #2076 is resolved. */
 
         [DllImport("jitstructtests_lib")]
         public static extern S20 InvokeCallback20R(MyCallback20 callback, S20 s);
-/* These tests are not working on non Windows CoreCLR.  Enable this when GH Issue #2076 is resolved.
+/* These tests are not working on non Windows CoreCLR.  Enable this when https://github.com/dotnet/coreclr/issues/2076 is resolved.
 
         [DllImport("jitstructtests_lib")]
         public static extern S28 InvokeCallback28R(MyCallback28 callback, S28 s);
 
         [DllImport("jitstructtests_lib")]
         public static extern S29 InvokeCallback29R(MyCallback29 callback, S29 s);
- Enable this when GH Issue #2076 is resolved. */        
+ Enable this when https://github.com/dotnet/coreclr/issues/2076 is resolved. */        
         static public int Main1()
         {
             Program3 p = new Program3();
@@ -642,7 +642,7 @@ static public int Main1()
                     }
                 }, s20);
 
-                /* These tests are not working on non Windows CoreCLR.  Enable this when GH Issue #2076 is resolved.
+                /* These tests are not working on non Windows CoreCLR.  Enable this when https://github.com/dotnet/coreclr/issues/2076 is resolved.
                 TestClass testClass = new TestClass();
                 S28 s28;
                 s28.x = null;
@@ -689,7 +689,7 @@ static public int Main1()
                         throw new System.Exception();
                     }
                 }, s29);
-                 Enable this when GH Issue #2076 is resolved. */
+                 Enable this when https://github.com/dotnet/coreclr/issues/2076 is resolved. */
                 S30 s30;
                 s30.x = 1;
                 s30.y = 2;
@@ -990,7 +990,7 @@ Enable this when GH Issue #2076 is resolved. */
                 {
                     throw new System.Exception();
                 }
-                /* These tests are not working on non Windows CoreCLR.  Enable this when GH Issue #2076 is resolved.
+                /* These tests are not working on non Windows CoreCLR.  Enable this when https://github.com/dotnet/coreclr/issues/2076 is resolved.
                 s28.x = null;
                 S28 s28r = InvokeCallback28R((par) => {
                     Console.WriteLine("S28: {0}, {1}", par.x == null ? "Null" : "Not null", par.y);
@@ -1049,7 +1049,7 @@ Enable this when GH Issue #2076 is resolved. */
                 {
                     throw new System.Exception();
                 }
-                 Enable this when GH Issue #2076 is resolved. */
+                 Enable this when https://github.com/dotnet/coreclr/issues/2076 is resolved. */
             }
             catch (Exception e)
             {

src/coreclr/tests/src/JIT/Performance/CodeQuality/Layout/SearchLoops.cs

@@ -10,7 +10,7 @@
 
 [assembly: OptimizeForBenchmarks]
 
-// Test code taken directly from GitHub issue #9692 (https://github.com/dotnet/coreclr/issues/9692)
+// Test code taken directly from https://github.com/dotnet/coreclr/issues/9692
 // Laying the loop's early return path in-line can cost 30% on this micro-benchmark.
 
 namespace Layout

src/coreclr/tests/src/JIT/Regression/JitBlue/GitHub_1161/GitHub_1161.cs

@@ -3,7 +3,7 @@
 // See the LICENSE file in the project root for more information.
 
 // This test illustrates a limitation in the JIT in that it will not promote
-// a struct that has a single double register. See GitHub issue #1161.
+// a struct that has a single double register. See https://github.com/dotnet/coreclr/issues/1161.
 
 using System;
 using System.Runtime.CompilerServices;

src/coreclr/tests/src/JIT/Regression/JitBlue/GitHub_11816/GitHub_11816.cs

@@ -2,7 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-// This test captures the redundant struct zeroing from GitHub issue #11816.
+// This test captures the redundant struct zeroing from https://github.com/dotnet/coreclr/issues/11816.
 // Since the issue was filed, the 'TestStructManuallyInlined' case has apparently
 // gotten worse, as there is a MEMSET of the large struct to 0.
 

src/coreclr/tests/src/JIT/Regression/JitBlue/GitHub_18259/GitHub_18259.cs

@@ -4,7 +4,7 @@
 
 using System;
 
-// Test case for issue 18259
+// Test case for https://github.com/dotnet/coreclr/issues/18259
 //
 // We were a missing check for ZeroOffsetFldSeq values on LclVar reads
 // 

src/coreclr/tests/src/JIT/Regression/JitBlue/GitHub_21231/GitHub_21231a.cs

@@ -4,7 +4,7 @@
 
 using System;
 
-// Test case for issue 21231
+// Test case for https://github.com/dotnet/coreclr/issues/21231
 //
 // 
 // Debug: Outputs 2

src/coreclr/tests/src/JIT/Regression/JitBlue/GitHub_21231/GitHub_21231b.cs

@@ -4,7 +4,7 @@
 
 using System;
 
-// Test case for issue 21231
+// Test case for https://github.com/dotnet/coreclr/issues/21231
 //
 // 
 // Debug: Outputs 2

src/coreclr/tests/src/JIT/Regression/JitBlue/GitHub_22820/GitHub_22820.cs

@@ -4,7 +4,8 @@
 
 using System;
 
-// Repro for issue 22820. On x86 we need to report enclosed handler
+// Repro for https://github.com/dotnet/coreclr/issues/22820.
+// On x86 we need to report enclosed handler
 // live-in locals as live into any enclosing filter.
 //
 // Run with optimized codegen and COMPlus_GCStress=0x4

src/coreclr/tests/src/JIT/Regression/JitBlue/GitHub_2580/GitHub_2580.cs

@@ -2,7 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-// Issue 2580 fix description
+// Issue https://github.com/dotnet/coreclr/issues/2580 fix description
 //
 // The changes fix a bug generating 16-bit signed comparison code to                                 
 // compare unsigned 16-bit values.                                                                   

src/coreclr/tests/src/JIT/Regression/JitBlue/GitHub_7508/Vector3Test.cs

@@ -2,8 +2,8 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-// Since Issue 7508 was a performance issue, there's not really a correctness
-// test for this.
+// Since https://github.com/dotnet/coreclr/issues/7508 was a performance issue,
+// there's not really a correctness test for this.
 // However, this is a very simple test that can be used to compare the code generated
 // for a non-accelerated vector of 3 floats, a "raw" Vector3 and a Vector3
 // wrapped in a struct.

src/coreclr/tests/src/JIT/SIMD/Vector3GetHash.cs

@@ -5,8 +5,9 @@
 // This was copied from corefx\src\System.Numerics.Vectors\tests\Vector3Tests.cs.
 // It exposed a bug in morph, in which a SIMD field was being morphed in
 // a MACK_Ind context, even though it was under a GT_IND(G_ADDR()).
-// This was corefx issue #15713, and was "fixed" with coreclr PR # 9496,
-// and a new issue, #9518, has been filed to track the underlying unexpected
+// This was https://github.com/dotnet/corefx/issues/15713, and was "fixed" with
+// https://github.com/dotnet/coreclr/issues/9496 and a new issue,
+// https://github.com/dotnet/coreclr/issues/9518, has been filed to track the underlying unexpected
 // MACK_Ind context, which causes us to mark the Vector3 local as do-not-enregister.
 
 using System;

src/coreclr/tests/src/JIT/opt/Structs/structpop.cs

@@ -5,7 +5,7 @@
 // Optimization of pop with struct types
 // Codegen for TestByRef and TestByPtr should be similar
 //
-// See CoreClr#18710
+// See https://github.com/dotnet/coreclr/issues/18710
 
 using System;
 using System.Runtime.CompilerServices;

src/coreclr/tests/src/JIT/opt/Structs/structpop2.cs

@@ -5,7 +5,7 @@
 // Optimization of pop with struct types
 // Codegen for TestByPtr should be minimal
 //
-// See CoreClr#18710
+// See https://github.com/dotnet/coreclr/issues/18710
 
 using System;
 using System.Runtime.CompilerServices;

src/coreclr/tests/src/Regressions/coreclr/GitHub_17398/test17398.cs

@@ -5,7 +5,7 @@
 using System;
 using System.Runtime.CompilerServices;
 
-// Repro case for CoreCLR 17398
+// Repro case for https://github.com/dotnet/coreclr/pull/17398
 
 class X
 {

src/coreclr/tests/src/baseservices/threading/waithandle/waitall/nullarray.cs

@@ -10,13 +10,13 @@ class Duplicates
 	static int Main()
 	{
 		int retCode = 99;
-
-		// Console.WriteLine(Thread.CurrentThread.GetApartmentState());
 
-		// Not supported (CoreCLR GitHub issue #2999)
-		// AppDomain.CurrentDomain.UnhandledException += Unhandled;
+        // Console.WriteLine(Thread.CurrentThread.GetApartmentState());
+
+        // Not supported (https://github.com/dotnet/coreclr/issues/2999)
+        // AppDomain.CurrentDomain.UnhandledException += Unhandled;
 
-		WaitHandle[] waitHandles = null;
+        WaitHandle[] waitHandles = null;
 
 		// Can't catch exception in v2.0. Should be fixed in Post-Orcas. VSWhidbey 543816
 		try 

src/libraries/Common/src/Interop/Windows/HttpApi/Interop.ErrorCodes.cs

@@ -4,7 +4,6 @@
 
 internal static partial class Interop
 {
-    // TODO #3562: Unify ErrorCodes.
     internal static partial class HttpApi
     {
         public const uint ERROR_SUCCESS = 0;

src/libraries/Common/src/Interop/Windows/IpHlpApi/Interop.ErrorCodes.cs

@@ -4,7 +4,6 @@
 
 internal static partial class Interop
 {
-    // TODO #3562: Unify ErrorCodes.
     internal static partial class IpHlpApi
     {
         public const uint ERROR_SUCCESS = 0;

src/libraries/Common/src/Interop/Windows/IpHlpApi/Interop.ICMP.cs

@@ -13,8 +13,6 @@ internal static partial class IpHlpApi
     {
         internal const int IP_STATUS_BASE = 11000;
 
-        // TODO: #3562 - Replace names with the ones from the Windows SDK.
-
         [StructLayout(LayoutKind.Sequential)]
         internal struct IPOptions
         {

src/libraries/Common/src/Interop/Windows/IpHlpApi/Interop.NetworkInformation.cs

@@ -15,8 +15,6 @@ internal static partial class Interop
 {
     internal static partial class IpHlpApi
     {
-        // TODO: #3562 - Replace names with the ones from the Windows SDK.
-
         [Flags]
         internal enum AdapterFlags
         {

src/libraries/Common/src/Interop/Windows/WinHttp/Interop.SafeWinHttpHandle.cs

@@ -52,7 +52,6 @@ protected override bool ReleaseHandle()
                     _parentHandle = null;
                 }
 
-                // TODO (#7856): Add logging so we know when the handle gets closed.
                 return Interop.WinHttp.WinHttpCloseHandle(handle);
             }
         }

src/libraries/Common/src/System/Net/CookieParser.cs

@@ -529,7 +529,7 @@ private static Func<Cookie, string, bool> InternalSetNameMethod
             {
                 if (s_internalSetNameMethod == null)
                 {
-                    // TODO: #13607
+                    // TODO https://github.com/dotnet/corefx/issues/13607:
                     // We need to use Cookie.InternalSetName instead of the Cookie.set_Name wrapped in a try catch block, as
                     // Cookie.set_Name keeps the original name if the string is empty or null.
                     // Unfortunately this API is internal so we use reflection to access it. The method is cached for performance reasons.
@@ -550,7 +550,7 @@ private static FieldInfo IsQuotedDomainField
             {
                 if (s_isQuotedDomainField == null)
                 {
-                    // TODO: #13607
+                    // TODO https://github.com/dotnet/corefx/issues/13607:
                     FieldInfo field = typeof(Cookie).GetField("IsQuotedDomain", BindingFlags.Instance | BindingFlags.NonPublic);
                     Debug.Assert(field != null, "We need to use an internal field named IsQuotedDomain that is declared on Cookie.");
                     s_isQuotedDomainField = field;
@@ -567,7 +567,7 @@ private static FieldInfo IsQuotedVersionField
             {
                 if (s_isQuotedVersionField == null)
                 {
-                    // TODO: #13607
+                    // TODO https://github.com/dotnet/corefx/issues/13607:
                     FieldInfo field = typeof(Cookie).GetField("IsQuotedVersion", BindingFlags.Instance | BindingFlags.NonPublic);
                     Debug.Assert(field != null, "We need to use an internal field named IsQuotedVersion that is declared on Cookie.");
                     s_isQuotedVersionField = field;

src/libraries/Common/src/System/Net/Http/Http2/Hpack/Huffman.cs

@@ -319,7 +319,8 @@ public static int Decode(ReadOnlySpan<byte> src, ref byte[] dstArray)
                 // Note that if lastDecodeBits is 3 or more, then we will only get 5 bits (or less)
                 // from src[i]. Thus we need to read 5 bytes here to ensure that we always have
                 // at least 30 bits available for decoding.
-                // TODO ISSUE 31751: Rework this as part of Huffman perf improvements
+                // TODO https://github.com/dotnet/runtime/issues/1506:
+                // Rework this as part of Huffman perf improvements
                 uint next = (uint)(src[i] << 24 + lastDecodedBits);
                 next |= (i + 1 < src.Length ? (uint)(src[i + 1] << 16 + lastDecodedBits) : 0);
                 next |= (i + 2 < src.Length ? (uint)(src[i + 2] << 8 + lastDecodedBits) : 0);

src/libraries/Common/src/System/Net/Security/NetEventSource.Security.cs

@@ -10,7 +10,6 @@
 
 namespace System.Net
 {
-    //TODO: If localization resources are not found, logging does not work. Issue #5126.
     internal sealed partial class NetEventSource
     {
         // Event ids are defined in NetEventSource.Common.cs.

src/libraries/Common/src/System/Net/WebSockets/ManagedWebSocket.cs

@@ -868,7 +868,6 @@ private async ValueTask WaitForServerToCloseConnectionAsync(CancellationToken ca
                     catch
                     {
                         // Eat any resulting exceptions.  We were going to close the connection, anyway.
-                        // TODO #24057: Log the exception to NetEventSource.
                     }
                 }
             }

src/libraries/Common/tests/CoreFx.Private.TestUtilities/System/PlatformDetection.cs

@@ -96,7 +96,7 @@ public static bool IsNonZeroLowerBoundArraySupported
 
         // Windows - Schannel supports alpn from win8.1/2012 R2 and higher.
         // Linux - OpenSsl supports alpn from openssl 1.0.2 and higher.
-        // OSX - SecureTransport doesn't expose alpn APIs. #30492
+        // OSX - SecureTransport doesn't expose alpn APIs. TODO https://github.com/dotnet/corefx/issues/33016
         public static bool SupportsAlpn => (IsWindows && !IsWindows7) ||
             ((!IsOSX && !IsWindows) &&
             (OpenSslVersion.Major >= 1 && (OpenSslVersion.Minor >= 1 || OpenSslVersion.Build >= 2)));
@@ -186,7 +186,7 @@ private static bool GetSsl3Support()
                 }
 
                 // Missing key. If we're pre-20H1 then assume SSL3 is enabled.
-                // Otherwise, disabled. (See Comments on dotnet/runtime#1166)
+                // Otherwise, disabled. (See comments on https://github.com/dotnet/runtime/issues/1166)
                 // Alternatively the returned values must have been some other types.
                 return !IsWindows10Version2004OrGreater;
             }