Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove libintl dependency #270

Merged
merged 2 commits into from
Nov 27, 2019
Merged

Remove libintl dependency #270

merged 2 commits into from
Nov 27, 2019

Conversation

am11
Copy link
Member

@am11 am11 commented Nov 26, 2019

Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@am11
Copy link
Member Author

am11 commented Nov 27, 2019

runtime-coreclr (Test crossgen-comparison Linux arm checked) timedout. unrelated?

@janvorli
Copy link
Member

runtime-coreclr (Test crossgen-comparison Linux arm checked) timedout. unrelated?

Yes, this test seems to timeout quite often.

@janvorli janvorli merged commit a89dcad into dotnet:master Nov 27, 2019
@am11 am11 deleted the feature/purge-libintl branch November 27, 2019 12:08
MichalStrehovsky pushed a commit to MichalStrehovsky/runtime that referenced this pull request Nov 4, 2020
* Fix native library sample

* Add smoke test from CoreRT

* Workaround for Linux bug

* Workaround test harness quirks
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants