Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually enable IOV features in createdump #31782

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Actually enable IOV features in createdump #31782

merged 1 commit into from
Feb 12, 2020

Conversation

nxtn
Copy link
Contributor

@nxtn nxtn commented Feb 5, 2020 •
edited

Continued from #420.

@nxtn nxtn changed the title Introduce IOV in ShimRemoteDataTarget Actually enables IOV features in createdump Feb 5, 2020
@nxtn nxtn changed the title Actually enables IOV features in createdump Actually enable IOV features in createdump Feb 5, 2020
@nxtn nxtn marked this pull request as ready for review February 5, 2020 11:35
@jkotas jkotas requested a review from mikem8361 February 5, 2020 14:05
@nxtn nxtn requested a review from jkotas February 12, 2020 03:22
jkotas
jkotas approved these changes Feb 12, 2020
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jkotas jkotas merged commit bc384e2 into dotnet:master Feb 12, 2020
@nxtn nxtn deleted the shimremote branch February 12, 2020 04:39
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

@mikem8361 mikem8361 mikem8361 approved these changes

Assignees
No one assigned
Labels
area-Diagnostics-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nxtn @jkotas @mikem8361