Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually enable IOV features in createdump #31782

Merged
merged 1 commit into from
Feb 12, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/coreclr/src/debug/createdump/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ project(createdump)

set(CMAKE_INCLUDE_CURRENT_DIR ON)

include(configure.cmake)

# Set the RPATH of createdump so that it can find dependencies without needing to set LD_LIBRARY_PATH
# For more information: http://www.cmake.org/Wiki/CMake_RPATH_handling.
if (CORECLR_SET_RPATH)
Expand Down
7 changes: 7 additions & 0 deletions src/coreclr/src/debug/createdump/config.h.in
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

#pragma once

#cmakedefine HAVE_PROCESS_VM_READV
3 changes: 3 additions & 0 deletions src/coreclr/src/debug/createdump/configure.cmake
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
check_function_exists(process_vm_readv HAVE_PROCESS_VM_READV)

configure_file(${CMAKE_CURRENT_SOURCE_DIR}/config.h.in ${CMAKE_CURRENT_BINARY_DIR}/config.h)
2 changes: 2 additions & 0 deletions src/coreclr/src/debug/createdump/createdump.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ extern bool g_diagnostics;
printf(args); \
}

#include "config.h"

#include <winternl.h>
#include <winver.h>
#include <windows.h>
Expand Down
1 change: 0 additions & 1 deletion src/coreclr/src/pal/src/configure.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,6 @@ check_function_exists(semget HAS_SYSV_SEMAPHORES)
check_function_exists(pthread_mutex_init HAS_PTHREAD_MUTEXES)
check_function_exists(ttrace HAVE_TTRACE)
check_function_exists(pipe2 HAVE_PIPE2)
check_function_exists(process_vm_readv HAVE_PROCESS_VM_READV)

check_cxx_source_compiles("
#include <pthread_np.h>
Expand Down