-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MulticastOption.Group no longer accepts null. #32518
Conversation
@ericstj knows where breaking changes should be mentioned. For dotnet-api-docs, I can help. |
@@ -67,6 +67,11 @@ public IPAddress Group | |||
} | |||
set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this API did not have triple slash comments, and is already documented in MS Docs, this new exception must be added here:
src/libraries/System.Net.Sockets/src/System/Net/Sockets/UdpReceiveResult.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Sockets/tests/FunctionalTests/MulticastOptionTest.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Sockets/src/System/Net/Sockets/MulticastOption.cs
Outdated
Show resolved
Hide resolved
MulticastOption.Group is not supposed to accept null. If someone sets it to null, we will NRE inside of the Sockets implementation. I also fixed two small double-cast problems while I was in here. Fix dotnet#32490
@eerhardt this is labeled breaking change. Can you please open an issue if necessary using https://github.com/dotnet/docs/issues/new?template=dotnet-breaking-change.md ? |
Done. dotnet/docs#19723 |
MulticastOption.Group is not supposed to accept null. If someone sets it to null, we will NRE inside of the Sockets implementation.
I also fixed two small double-cast problems while I was in here.
Fix #32490
Note that this is a breaking change. I'm not sure all the ways I'm supposed to document this. If anyone has thoughts, please let me know.