-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation of stateful CBOR writer and reader classes #32803
Conversation
src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborDataItem.cs
Outdated
Show resolved
Hide resolved
...stem.Security.Cryptography.Encoding/tests/System.Security.Cryptography.Encoding.Tests.csproj
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborWriter.String.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborWriter.Integer.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborReader.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborReader.String.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborReader.Integer.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborDataItem.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborDataItem.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborDataItem.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborReader.Integer.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborReader.Integer.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborReader.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.Encoding/tests/Cbor.Tests/CborReaderTests.Integer.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.Encoding/tests/Cbor.Tests/CborReaderTests.Integer.cs
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborReader.Integer.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborReader.Integer.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborReader.String.cs
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborReader.String.cs
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborReader.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.Encoding/tests/Cbor.Tests/CborWriterTests.Integer.cs
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.Encoding/tests/Cbor.Tests/CborWriterTests.Integer.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.Encoding/tests/Cbor.Tests/CborWriterTests.String.cs
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborReader.String.cs
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborReader.String.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.Encoding/tests/Cbor.Tests/CborReaderTests.Integer.cs
Show resolved
Hide resolved
2776a6a
to
bb05802
Compare
What's here looks reasonable, modulo either testing or removing the TryRead methods for the integer types. I'm trying to rediscover how to get a test coverage report to include the test assembly, but the obvious things are eluding me. |
The best I've come up with so far:
Then edit the runtests.bat that's generated and add I don't see an obvious way to get that into the command sequence built from https://github.com/dotnet/runtime/blob/master/eng/testing/coverage.targets; though I would have sworn it used to be. Maybe I'm just not being clever enough. |
src/libraries/System.Security.Cryptography.Encoding/tests/Cbor.Tests/CborReaderTests.Integer.cs
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborReader.String.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborReader.String.cs
Outdated
Show resolved
Hide resolved
…/CborReader.String.cs Co-Authored-By: Jeremy Barton <jbarton@microsoft.com>
…/CborReader.String.cs Co-Authored-By: Jeremy Barton <jbarton@microsoft.com>
Test failures are all System.Reflection and System.Runtime.Loader related. |
Do you think it might make sense to move to the main project and keep types internal? |
Contributes to #32046 and #32047.
This is an initial, prototype-grade implementation of stateful CBOR reader and writer types.