Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial implementation of stateful CBOR writer and reader classes #32803

Merged
merged 33 commits into from
Mar 4, 2020
Merged

Initial implementation of stateful CBOR writer and reader classes #32803

merged 33 commits into from
Mar 4, 2020

Commits on Feb 28, 2020

  1. initial CborReader commit

    @eiriktsarpalis
    eiriktsarpalis committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    c220624 View commit details
    Browse the repository at this point in the history

  2. rename PositiveInteger to UnsignedInteger

    @eiriktsarpalis
    eiriktsarpalis committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    301e593 View commit details
    Browse the repository at this point in the history

  3. fix indices in unsigned integer encoding

    @eiriktsarpalis
    eiriktsarpalis committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    d70f5ae View commit details
    Browse the repository at this point in the history

  4. use an enum for AdditionalInfo constants

    @eiriktsarpalis
    eiriktsarpalis committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    ecbd659 View commit details
    Browse the repository at this point in the history

  5. s/ArgumentException/InvalidOperationException/

    @eiriktsarpalis
    eiriktsarpalis committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    21dfcb7 View commit details
    Browse the repository at this point in the history

  6. make utf8 decoder throw on invalid bytes

    @eiriktsarpalis
    eiriktsarpalis committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    a262a37 View commit details
    Browse the repository at this point in the history

  7. remove property-based tests

    @eiriktsarpalis
    eiriktsarpalis committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    6924fe6 View commit details
    Browse the repository at this point in the history

  8. address style

    @eiriktsarpalis
    eiriktsarpalis committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    b4d2ebb View commit details
    Browse the repository at this point in the history

  9. just copy the header struct for now

    @eiriktsarpalis
    eiriktsarpalis committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    03e9616 View commit details
    Browse the repository at this point in the history

  10. s/CborReader/CborValueReader/

    @eiriktsarpalis
    eiriktsarpalis committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    544872d View commit details
    Browse the repository at this point in the history

  11. address feedback

    @eiriktsarpalis
    eiriktsarpalis committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    5b75a0a View commit details
    Browse the repository at this point in the history

  12. add more test cases in the happy path

    @eiriktsarpalis
    eiriktsarpalis committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    5d361b0 View commit details
    Browse the repository at this point in the history

  13. remove using declaration

    @eiriktsarpalis
    eiriktsarpalis committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    e08abd1 View commit details
    Browse the repository at this point in the history

  14. fix the seed parameter

    @eiriktsarpalis
    eiriktsarpalis committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    dd72ca4 View commit details
    Browse the repository at this point in the history

  15. add EnsureBuffer() method in reader

    @eiriktsarpalis
    eiriktsarpalis committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    16ef7d8 View commit details
    Browse the repository at this point in the history

  16. add tests for artihmetic overflow and type exceptions

    @eiriktsarpalis
    eiriktsarpalis committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    865d964 View commit details
    Browse the repository at this point in the history

  17. rename CborDateItem to CborInitialByte and expose reader Peek() methods

    @eiriktsarpalis
    eiriktsarpalis committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    5138baa View commit details
    Browse the repository at this point in the history

  18. add tests for non-canonical integer encodings

    @eiriktsarpalis
    eiriktsarpalis committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    a30e79e View commit details
    Browse the repository at this point in the history

  19. use hex representation when asserting byte array equality

    @eiriktsarpalis
    eiriktsarpalis committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    a63e6e5 View commit details
    Browse the repository at this point in the history

  20. add format and invalidop exception tests

    @eiriktsarpalis
    eiriktsarpalis committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    adc4263 View commit details
    Browse the repository at this point in the history

  21. consistent test terminology

    @eiriktsarpalis
    eiriktsarpalis committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    3fa2dcf View commit details
    Browse the repository at this point in the history

  22. add invalid unicode writing test

    @eiriktsarpalis
    eiriktsarpalis committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    4752629 View commit details
    Browse the repository at this point in the history

  23. add string reader failure tests

    @eiriktsarpalis
    eiriktsarpalis committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    3ebc62f View commit details
    Browse the repository at this point in the history

  24. fix failing test

    @eiriktsarpalis
    eiriktsarpalis committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    bb05802 View commit details
    Browse the repository at this point in the history

  25. add peek tests

    @eiriktsarpalis
    eiriktsarpalis committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    659f888 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2020

  1. implement ReadCborNegativeIntegerEncoding(); remove TryRead() methods… 

    … for integer types
    @eiriktsarpalis
    eiriktsarpalis committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    339262e View commit details
    Browse the repository at this point in the history

  2. add span overloads for string reader methods

    @eiriktsarpalis
    eiriktsarpalis committed Mar 3, 2020
    5 Configuration menu
    Copy the full SHA
    f662113 View commit details
    Browse the repository at this point in the history

  3. update string reader span overload signatures

    @eiriktsarpalis
    eiriktsarpalis committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    2ea14e1 View commit details
    Browse the repository at this point in the history

  4. add format and invalidop exception tests for TryRead() string methods

    @eiriktsarpalis
    eiriktsarpalis committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    c5c4587 View commit details
    Browse the repository at this point in the history

  5. add tests for failure modes

    @eiriktsarpalis
    eiriktsarpalis committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    882f9d7 View commit details
    Browse the repository at this point in the history

  6. Update src/libraries/System.Security.Cryptography.Encoding/tests/Cbor… 

    …/CborReader.String.cs

Co-Authored-By: Jeremy Barton <jbarton@microsoft.com>
    @eiriktsarpalis @bartonjs
    eiriktsarpalis and bartonjs committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    f13cea7 View commit details
    Browse the repository at this point in the history

  7. Update src/libraries/System.Security.Cryptography.Encoding/tests/Cbor… 

    …/CborReader.String.cs

Co-Authored-By: Jeremy Barton <jbarton@microsoft.com>
    @eiriktsarpalis @bartonjs
    eiriktsarpalis and bartonjs committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    fe8fe24 View commit details
    Browse the repository at this point in the history

  8. fix build

    @eiriktsarpalis
    eiriktsarpalis committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    29f4142 View commit details
    Browse the repository at this point in the history