Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement CBOR array support #33302

Merged
merged 15 commits into from
Mar 11, 2020
Merged

Implement CBOR array support #33302

merged 15 commits into from
Mar 11, 2020

Commits on Mar 6, 2020

  1. Implement array support for CborWriter

    @eiriktsarpalis
    eiriktsarpalis committed Mar 6, 2020
    Configuration menu
    Copy the full SHA
    f0e212a View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2020

  1. convert CborReader to class

    @eiriktsarpalis
    eiriktsarpalis committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    6414d76 View commit details
    Browse the repository at this point in the history

  2. add CborReaderState enum

    @eiriktsarpalis
    eiriktsarpalis committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    785a634 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2020

  1. Implement CborReader array support

    @eiriktsarpalis
    eiriktsarpalis committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    1b2cc6d View commit details
    Browse the repository at this point in the history

  2. refactor reader tests

    @eiriktsarpalis
    eiriktsarpalis committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    68e28a1 View commit details
    Browse the repository at this point in the history

  3. add peek state assertions in happy path tests

    @eiriktsarpalis
    eiriktsarpalis committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    0048b3a View commit details
    Browse the repository at this point in the history

  4. remove redundant assertion

    @eiriktsarpalis
    eiriktsarpalis committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    2e2f72f View commit details
    Browse the repository at this point in the history

  5. Update src/libraries/System.Security.Cryptography.Encoding/tests/Cbor… 

    ….Tests/CborReaderTests.Array.cs

Co-Authored-By: Jeremy Barton <jbarton@microsoft.com>
    @eiriktsarpalis @bartonjs
    eiriktsarpalis and bartonjs committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    dee6149 View commit details
    Browse the repository at this point in the history

  6. Update src/libraries/System.Security.Cryptography.Encoding/tests/Cbor… 

    ….Tests/CborWriterTests.Array.cs

Co-Authored-By: Jeremy Barton <jbarton@microsoft.com>
    @eiriktsarpalis @bartonjs
    eiriktsarpalis and bartonjs committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    11365f6 View commit details
    Browse the repository at this point in the history

  7. address feedback

    @eiriktsarpalis
    eiriktsarpalis committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    fc550e8 View commit details
    Browse the repository at this point in the history

  8. styling

    @eiriktsarpalis
    eiriktsarpalis committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    7adccc6 View commit details
    Browse the repository at this point in the history

  9. BeginWriteArray -> WriteStartArray

    @eiriktsarpalis
    eiriktsarpalis committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    f923e98 View commit details
    Browse the repository at this point in the history

  10. rename CborReaderState.EOF to CborReaderState.EndOfData

    @eiriktsarpalis
    eiriktsarpalis committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    0b1ba32 View commit details
    Browse the repository at this point in the history

  11. add BytesRead and BytesWritten properties

    @eiriktsarpalis
    eiriktsarpalis committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    73885df View commit details
    Browse the repository at this point in the history

  12. add an Unknown enum case for zero values

    @eiriktsarpalis
    eiriktsarpalis committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    c5ef23c View commit details
    Browse the repository at this point in the history