Don't pass the managed array object down when clearing a native array field. #33830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jkoritzinsky This looks okay to me. In this case, I think we should also have a simple test to validate at least the scenario that was reported is valid. What class of marshaling is missing from our test coverage that missed this? |
|
This case in particular is a non-blittable struct with an array field nested within another struct at a non-zero offset. I'll add the repro as a test case where our test cases for Marshal.DestroyStructure live. |
AaronRobinsonMSFT
approved these changes
Mar 19, 2020
|
Hello @jkoritzinsky! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can construct all of the information we need from the method table and the managed object isn't actually used anywhere. Additionally, we don't always have a managed object when clearing the native object, see #33703
Fixes #33703