Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement icall used by RuntimeHelpers.EnsureSufficientExecutionStack on netcore Mono. #33857

Merged
merged 1 commit into from
Mar 24, 2020

Commits on Mar 23, 2020

  1. Implement icall used by RuntimeHelpers.EnsureSufficientExecutionStack…

    … on netcore Mono.
    
    Current implementation always returned true for Windows/Linux/Android.
    There are however use of this API in Task library to make sure recursive
    tasks won't hit stackoverflow. There are several tests in System.Threading.Tasks
    that currently hit this, at least on Windows, causing test failures.
    
    Fix use stack limits already setup in register_thread and used by GC when
    doing conservative stack scan. If the limits have not been setup or is not
    supported on platform, we will use old defaults, always assume there is
    enough stack space available. Heuristics around size of minimum execution
    stack needed are picked from corresponding CoreCLR implementation.
    lateralusX committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    edbb000 View commit details
    Browse the repository at this point in the history