Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add service name to System.ServiceProcess.TimeoutException message #33927

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Add service name to System.ServiceProcess.TimeoutException message #33927

merged 1 commit into from
Mar 23, 2020

Conversation

Fs00
Copy link
Contributor

@Fs00 Fs00 commented Mar 22, 2020 •
edited
Loading

This small PR adds the service name to the message of the TimeoutException raised by method WaitForStatus.
This is very useful in the following scenario where a service depends on other services:

  • the user calls Stop on the service, which tries to stops all the dependent services first
  • one of the dependent services cannot be stopped in time and therefore raises a TimeoutException, but the user does not know which service caused it

Related to issue #765.

@dnfclas
Copy link

dnfclas commented Mar 22, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

stephentoub
stephentoub approved these changes Mar 22, 2020
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @danmosemsft

@Fs00 Fs00 mentioned this pull request Mar 22, 2020
Merged
danmoseley
danmoseley approved these changes Mar 22, 2020
View reviewed changes
Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@stephentoub stephentoub merged commit 3437496 into dotnet:master Mar 23, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@danmoseley danmoseley danmoseley approved these changes

Assignees
No one assigned
Labels
area-System.ServiceProcess
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Fs00 @dnfclas @stephentoub @danmoseley @Dotnet-GitSync-Bot