Moving more Tfm specific properties to the targetFramework.props file

[Anipik]

No description provided.

[ericstj]

This is a good step in the right direction. Did you look at every property that was moved to ensure there weren't further derived properties? Assuming so, then a next step could be to try to eliminate all usage of the properties now in targetframework.props from propertygroups in props files / project bodies (so that we can support defining TargetFramework in the project body).

[ViktorHofer]

Thanks for doing this. Can you please file an issue for the follow-up work which is making sure that TargetFramework is never read before the project file is loaded?

[Anipik]

did you look at every property that was moved to ensure there weren't further derived properties?

The only tfm properties are left for manual shims. We need to keep them to add manual keyword in the path to avoid having the conflicts with generated shims

Can you please file an issue for the follow-up work which is making sure that TargetFramework is never read before the project file is loaded?

yeah i will do that.

[ViktorHofer]

Why are you removing the TargetFrameworkSuffix here?

[ViktorHofer]

What about RestoreOutputPath, ProjectAssetsFile and MSBuildProjectExtensionsPath above, which all derive from IntermediateOutputPath which derives from TargetFramework.

[Anipik]

As eric mentioned , the next step is to remove the usage of all properties in targetFramework.props from propertyGroups.
eg all these properties will be the candidate for that.

[Anipik]

Why are you removing the TargetFrameworkSuffix here?

This was a bug. TargetFrameworkSuffix is a property for innerBuilds and is not defined for outer builds and should not be used in outer build. AdditionalBuildTargetFrameworks is used only in outerbuilds.

[ViktorHofer]

I'm unsure what's the scope of this PR. Isn't the goal to fix the broken intermediate/output paths? An example:

[Anipik]

The scope is just cleanup, nothing is getting fixed here.