Fix System.Data.SqlClient baseline #34352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we update the compat pack to depend on 4.8.1 as well? |
I have no idea, I'll take your word for it :D |
ericstj
approved these changes
Apr 1, 2020
|
Failure appears to be common regression caused by #34000 |
|
@ericstj I'm going to port this to preview3's branch and send the shiproom template. |
mmitche
added a commit
to mmitche/runtime
that referenced
this pull request
Apr 1, 2020
* Fix System.Data.SqlClient version Fixes dotnet#34351 * Update Microsoft.Windows.Compatibility.pkgproj
danmoseley
pushed a commit
that referenced
this pull request
Apr 1, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34351