Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R2RDump fixes for parsing composite images #34429

Merged
merged 1 commit into from
Apr 2, 2020

Conversation

trylek
Copy link
Member

@trylek trylek commented Apr 1, 2020

  1. Fixed several inconsistencies w.r.t. signature context in
    recursive descent into generic signatures based on offline
    investigation with JanV.

  2. Don't crash the dump upon invalid UTF8 characters.

Thanks

Tomas

1. Fixed several inconsistencies w.r.t. signature context in
recursive descent into generic signatures based on offline
investigation with JanV.

2. Don't crash the dump upon invalid UTF8 characters.

Thanks

Tomas
@trylek trylek added the area-R2RDump-coreclr Ready-to-run image dump tool label Apr 1, 2020
@trylek trylek requested review from janvorli and cshung April 1, 2020 22:14
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@trylek
Copy link
Member Author

trylek commented Apr 2, 2020

Merging in with one known issue - #34015.

@trylek trylek merged commit a95705d into dotnet:master Apr 2, 2020
@trylek trylek deleted the R2RDumpCompositeChanges branch April 2, 2020 12:52
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-R2RDump-coreclr Ready-to-run image dump tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants