Fix building WinRT tests on new Windows SDK (with new cppwinrt). #34513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jashook
approved these changes
Apr 3, 2020
jaredpar
approved these changes
Apr 3, 2020
|
Linux x64 test run failure was a networking blip that caused the .NET SDK to not be downloaded. Exact error message is as follows: |
safern
approved these changes
Apr 3, 2020
|
@jaredpar does this need to get backported to the 5.0 preview 3 branch? |
|
Yes we need to port this to not disrupt preview3 |
ViktorHofer
pushed a commit
to ViktorHofer/runtime
that referenced
this pull request
Apr 6, 2020
|
@jkoritzinsky opened #34585. |
ViktorHofer
added a commit
that referenced
this pull request
Apr 6, 2020
) (#34585) Co-authored-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the CoreCLR test build on the new VS 16.5.1 build queue.