-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test build target agnostic separately from target specific tests #34658
Conversation
Instead of generic filtering add a manual property
Tagging @ViktorHofer as an area owner |
I tested manually building on Linux. It looks good to me. |
The simple filtering used in this PR is relatively slow. It takes a while for MSBuild to find the tests to build (when finding the small set of target specific tests). Generic filtering may be slower. It is possible we may need to build test lists to make this faster.... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we do a string for CLRTestNeedTargetToBuild
s value instead of an opaque number that has to be documented somewhere else?
You're going to make me do the hard work of naming the states. Effectively right now the states are
@jkoritzinsky How does |
Those work. We could also shorten them to "TargetGeneric" and "TargetSpecific" if you would like. |
What about the script option? Sounds like they should change to
or
|
I agree with @jkoritzinsky's suggestions. Other than that, LGTM! I'm assuming the test lists building would be done in a separate PR? |
Both are fine by me. I would vote for the latter choices. Since the script is already called |
@VSadov Is working on generic filtering. I was assuming we would wait and see what he comes up with before engineering another solution, |
I made the renames per feedback. I also did a quick benchmark of test building on my local Hyper-V Ubuntu machine. It took |
quick benchmark - Windows results were about the same as Linux Hyper-V on the same machine. |
Part of #33066
Modifies build-test to add options to allow building target agnostic tests separately from target specific tests.
TraitTag
s found a few cases whereTraitTag
s were missed in Added OS and Bit Specific tags to accordingly .csproj files. #637. Also addedArchSpecific
CLRTestNeedTarget
to indicate a test which is not target agnostic.AnyOS
andAnyCPU
, but I ran into lots of issues. So I reverted that.