Added OS and Bit Specific tags to accordingly .csproj files. #637
Conversation
ivdiazsa
added
area-Infrastructure-coreclr
test-enhancement
Formally, no. In the discussions held with @VSadov, @jashook, and @trylek, we came up with other possibilities, such as GCLongRunning and GCStressIncompatible, but those ought to be treated with care. So, the decision was to just formalize the two I added and, as the include/exclude mechanism is developed, adding them as necessary. |
| @@ -11,4 +11,7 @@ | |||
| <ItemGroup> | |||
| <Compile Include="$(MSBuildProjectName).cs" /> | |||
| </ItemGroup> | |||
| <ItemGroup> | |||
There was a problem hiding this comment.
Is this supposed to be the TagList ? I actually like TraitTags more, just want to confirm this is intentional use of the name.
There was a problem hiding this comment.
Yes, TraitTags is the name currently given to the taglist.
There was a problem hiding this comment.
I must admit I give a damn about the actual identifier. As you two guys are mostly working on this now and no work has been done to support these in the actual test projects AFAIK, I guess you two just figure out whatever naming you're happy with.
There was a problem hiding this comment.
Me too :-) . Just wanted to make sure this is not something different.
TraitTags sounds good to me.
ghost
locked as resolved and limited conversation to collaborators
As part of the test build infrastructure changes, tags determining OS-specific, Bitness-Specific, and other behaviors will be added to the necessary project files. This will be used in the future by an include/exclude mechanism for builds. By looking into preprocessor directives in the test files, this PR adds the first two tags mentioned before.