[release/5.0-preview3] Fix WriteLargeJsonToStreamWithoutFlushing test (#34489) #34914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layomia
changed the title
layomia
changed the title
danmoseley
added
Servicing-approved
|
@layomia approved -- for test-only change, just an OK by a lead is fine. No need to set "servicing-xxx" label -- that pops it onto the radar of the Tactics meeting, who don't care about test only changes. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ports #34489 to preview 3 branch.
Fixes #34887.
This test wasn't updated following #32587 (introduced in preview 3), where the exception for the scenario changed from
OverflowExceptiontoOutOfMemoryException.Impact
The test failure appears to be blocking a clean CI run for the preview 3 branch: #34887. Not sure how crucial a fix here is but opening for consideration.