Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using the new sdk hook #35799

Merged
merged 2 commits into from
May 7, 2020
Merged

using the new sdk hook #35799

merged 2 commits into from
May 7, 2020

Conversation

Anipik
Copy link
Contributor

@Anipik Anipik commented May 4, 2020

Fixes #34525

-> Intellisense is working.
-> no need to override any outputpath dependent properties.
-> no more tfm dependent properties

@ghost
Copy link

ghost commented May 4, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@Anipik Anipik requested a review from safern May 4, 2020 17:35
@Anipik
Copy link
Contributor Author

Anipik commented May 4, 2020

People will need to update the machines to the preview5 sdk in order to use the intellisense.

@safern
Copy link
Member

safern commented May 4, 2020

People will need to update the machines to the preview5 sdk in order to use the intellisense.

Did we update global.json already?

@ViktorHofer
Copy link
Member

We already upgraded the SDK today with a1af15d. That version should be sufficient.

@ViktorHofer
Copy link
Member

@ericstj PTAL :)

@Anipik Anipik merged commit 43f948b into dotnet:master May 7, 2020
@Anipik Anipik deleted the newSdk branch May 7, 2020 05:10
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eliminate the use of properties defined in targetframework.props
5 participants