Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SafeProcessHandle.Unix: fix missing DangerousRelease #37412

Merged
merged 1 commit into from
Jun 4, 2020
Merged

SafeProcessHandle.Unix: fix missing DangerousRelease #37412

merged 1 commit into from
Jun 4, 2020

Conversation

tmds
Copy link
Member

@tmds tmds commented Jun 4, 2020

Because the SafeProcessHandle was not owned, ReleaseHandle was
not called, causing the wrapped SafeWaitHandle to never release
its resources.

Fixes #36661

cc @stephentoub

@tmds
SafeProcessHandle.Unix: fix missing DangerousRelease
5b258d4 
Because the SafeProcessHandle was not owned, ReleaseHandle was
not called, causing the wrapped SafeWaitHandle to never release
its resources.
@ghost
Copy link

ghost commented Jun 4, 2020

Tagging subscribers to this area: @eiriktsarpalis
Notify danmosemsft if you want to be subscribed.

stephentoub
stephentoub approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephentoub stephentoub merged commit 13fbbee into dotnet:master Jun 4, 2020
@jaredpar jaredpar mentioned this pull request Jun 4, 2020
Closed
danmoseley pushed a commit to danmoseley/runtime that referenced this pull request Jun 4, 2020
@tmds @danmoseley
SafeProcessHandle.Unix: fix missing DangerousRelease (dotnet#37412)
48dad46 
Because the SafeProcessHandle was not owned, ReleaseHandle was
not called, causing the wrapped SafeWaitHandle to never release
its resources.
@danmoseley danmoseley mentioned this pull request Jun 4, 2020
Merged
danmoseley added a commit that referenced this pull request Jun 5, 2020
@danmoseley @tmds
SafeProcessHandle.Unix: fix missing DangerousRelease (#37412) (#37446)
4ba9eca 
Because the SafeProcessHandle was not owned, ReleaseHandle was
not called, causing the wrapped SafeWaitHandle to never release
its resources.

Co-authored-by: Tom Deseyn <tom.deseyn@gmail.com>
@danmoseley danmoseley mentioned this pull request Jun 29, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees
No one assigned
Labels
area-System.Diagnostics.Process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression: Memory leak when launching child processes
3 participants
@tmds @stephentoub @Dotnet-GitSync-Bot