Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Array.Empty in CompositeFileProvider #38086

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

lindexi
Copy link
Contributor

@lindexi lindexi commented Jun 18, 2020

No description provided.

@ghost
Copy link

ghost commented Jun 18, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@stephentoub
Copy link
Member

@maryamariyan, this would have been caught by our static analysis, but it's been explicitly disabled:

<PropertyGroup Condition="$(MSBuildProjectName.StartsWith('Microsoft.Extensions.'))">
<IsAspNetCoreApp>true</IsAspNetCoreApp>
<!-- Temporarily ignore nit warning/errors (e.g. extra whitespace) from Extensions projects -->
<NoWarn Condition="!$(MSBuildProjectName.EndsWith('.Tests'))">$(NoWarn);SA1129;SA1028;SA1027;SA1121;CA1200;SA1000;CA1507;CA1802;CA1825;CA1018;SA1648;CA2007;SA1001;SA1026;CA1810;SA1206</NoWarn>
<NoWarn Condition="!$(MSBuildProjectName.Contains('ref'))">$(NoWarn);CS0618</NoWarn>
</PropertyGroup>

Is there an issue tracking re-enabling that?

@stephentoub
Copy link
Member

Is there an issue tracking re-enabling that?

I went ahead and fixed them.
#38090

@maryamariyan
Copy link
Member

@stephentoub Thanks for the fix. Yes. I was keeping track here: #37821

@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants