Fix code analysis warnings in Microsoft.Extensions.* (and stop suppressing warnings) #38090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
force-pushed
the
extensionswarnings
branch
from
619d882
to
49a21b7
Compare
safern
reviewed
Jun 19, 2020
src/libraries/Microsoft.Extensions.DependencyInjection/src/ServiceLookup/CallSiteFactory.cs
Outdated
Show resolved
Hide resolved
safern
reviewed
Jun 19, 2020
...es/Microsoft.Extensions.DependencyModel/src/Resolution/PackageCompilationAssemblyResolver.cs
Outdated
Show resolved
Hide resolved
safern
reviewed
Jun 19, 2020
src/libraries/Microsoft.Extensions.Primitives/src/StringValues.cs
Outdated
Show resolved
Hide resolved
safern
approved these changes
Jun 19, 2020
safern
reviewed
Jun 19, 2020
...braries/Microsoft.Extensions.DependencyModel/src/Resolution/ReferenceAssemblyPathResolver.cs
Outdated
Show resolved
Hide resolved
safern
reviewed
Jun 19, 2020
src/libraries/Microsoft.Extensions.Primitives/src/StringValues.cs
Outdated
Show resolved
Hide resolved
safern
reviewed
Jun 19, 2020
src/libraries/Microsoft.Extensions.Primitives/src/StringValues.cs
Outdated
Show resolved
Hide resolved
safern
reviewed
Jun 19, 2020
src/libraries/Microsoft.Extensions.Primitives/src/StringValues.cs
Outdated
Show resolved
Hide resolved
|
@stephentoub thanks for the PR. Do you mind also removing the fixed NoWarns (e.g. SA1001, SA1121, CA1200, CA2007, CA1810, CA1802, CA1825, CA1200, CA1507, SA1026, SA1129, SA1206, CA1018, SA1648) from this line: https://github.com/dotnet/runtime/blob/master/src/libraries/Directory.Build.props#L10 I was keeping track of this action item in issue #37821 UPDATE. As I was going through the diff commit by commit I noticed you made this change already. Thanks. |
maryamariyan
approved these changes
Jun 19, 2020
stephentoub
force-pushed
the
extensionswarnings
branch
from
49a21b7
to
494d2e5
Compare
|
Thanks for catching those, @safern. Deleted. |
|
The unvarening, maybe we should just be consistent between repos at this point |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #37821
cc: @maryamariyan, @eerhardt, @safern, @carlossanlop