Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experimental changes to try and capture dumps from CI #38309

Closed
wants to merge 2 commits into from
Closed

Experimental changes to try and capture dumps from CI #38309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19ab00a
Experimental changes to try and capture dumps from CI
AndyAyersMS Jun 24, 2020
eff0a86
proper check for default value
AndyAyersMS Jun 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/coreclr/src/inc/clrconfigvalues.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,6 +618,11 @@ CONFIG_DWORD_INFO(INTERNAL_OSR_LowId, W("OSR_LowId"), (DWORD)-1, "Low end of ena
CONFIG_DWORD_INFO(INTERNAL_OSR_HighId, W("OSR_HighId"), 10000000, "High end of enabled patchpoint range (inclusive)");
#endif

///
/// Hack
///
RETAIL_CONFIG_DWORD_INFO(INTERNAL_ExpectedExitCode, W("ExpectedExitCode"), 0, "expected process exit code");

///
/// Profile Guided Opts
///
Expand Down
13 changes: 13 additions & 0 deletions src/coreclr/src/vm/corhost.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,19 @@ HRESULT CorHost2::ExecuteAssembly(DWORD dwAppDomainId,
}
}

#if _DEBUG
if (pReturnValue)
{
// Hack, reusing existing config value
DWORD expectedValue = CLRConfig::GetConfigValue(CLRConfig::INTERNAL_ExpectedExitCode);

if (expectedValue != 0)
{
_ASSERTE(*pReturnValue == expectedValue);
}
}
#endif

GCPROTECT_END();
}

Expand Down
18 changes: 0 additions & 18 deletions src/coreclr/tests/issues.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,24 +118,6 @@
<ExcludeList Include="$(XunitTestBinBase)/baseservices/mono/runningmono/*">
<Issue>This test is to verify we are running mono, and therefore only makes sense on mono.</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical/xxobj/sizeof/_il_dbgsizeof32_Target_32Bit/*">
<Issue>https://github.com/dotnet/runtime/issues/37470</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical/xxobj/sizeof/_il_dbgsizeof64/*">
<Issue>https://github.com/dotnet/runtime/issues/37470</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical/xxobj/sizeof/_il_dbgsizeof_Target_32Bit/*">
<Issue>https://github.com/dotnet/runtime/issues/37470</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical/xxobj/sizeof/_il_relsizeof32_Target_32Bit/*">
<Issue>https://github.com/dotnet/runtime/issues/37470</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical/xxobj/sizeof/_il_relsizeof64_Target_32Bit/*">
<Issue>https://github.com/dotnet/runtime/issues/37470</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical/xxobj/sizeof/_il_relsizeof_Target_32Bit/*">
<Issue>https://github.com/dotnet/runtime/issues/37470</Issue>
</ExcludeList>
</ItemGroup>

<!-- All Unix targets on all runtimes -->
Expand Down
10 changes: 10 additions & 0 deletions src/coreclr/tests/src/JIT/Methodical/xxobj/sizeof/_il_dbgsizeof32_Target_32Bit.ilproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,14 @@
<ItemGroup>
<Compile Include="sizeof32.il" />
</ItemGroup>
<PropertyGroup>
<CLRTestBatchPreCommands><![CDATA[
$(CLRTestBatchPreCommands)
set COMPlus_ExpectedExitCode=64
]]></CLRTestBatchPreCommands>
<BashCLRTestPreCommands><![CDATA[
$(BashCLRTestPreCommands)
export COMPlus_ExpectedExitCode=64
]]></BashCLRTestPreCommands>
</PropertyGroup>
</Project>
10 changes: 10 additions & 0 deletions src/coreclr/tests/src/JIT/Methodical/xxobj/sizeof/_il_dbgsizeof64.ilproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,14 @@
<Compile Condition="'$(TargetArchitecture)' == 'x86'" Include="sizeof64.il" />
<Compile Condition="'$(TargetArchitecture)' != 'x86'" Include="64sizeof64.il" />
</ItemGroup>
<PropertyGroup>
<CLRTestBatchPreCommands><![CDATA[
$(CLRTestBatchPreCommands)
set COMPlus_ExpectedExitCode=64
]]></CLRTestBatchPreCommands>
<BashCLRTestPreCommands><![CDATA[
$(BashCLRTestPreCommands)
export COMPlus_ExpectedExitCode=64
]]></BashCLRTestPreCommands>
</PropertyGroup>
</Project>
10 changes: 10 additions & 0 deletions src/coreclr/tests/src/JIT/Methodical/xxobj/sizeof/_il_dbgsizeof_Target_32Bit.ilproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,14 @@
<ItemGroup>
<Compile Include="sizeof.il" />
</ItemGroup>
<PropertyGroup>
<CLRTestBatchPreCommands><![CDATA[
$(CLRTestBatchPreCommands)
set COMPlus_ExpectedExitCode=64
]]></CLRTestBatchPreCommands>
<BashCLRTestPreCommands><![CDATA[
$(BashCLRTestPreCommands)
export COMPlus_ExpectedExitCode=64
]]></BashCLRTestPreCommands>
</PropertyGroup>
</Project>
10 changes: 10 additions & 0 deletions src/coreclr/tests/src/JIT/Methodical/xxobj/sizeof/_il_relsizeof32_Target_32Bit.ilproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,14 @@
<ItemGroup>
<Compile Include="sizeof32.il" />
</ItemGroup>
<PropertyGroup>
<CLRTestBatchPreCommands><![CDATA[
$(CLRTestBatchPreCommands)
set COMPlus_ExpectedExitCode=64
]]></CLRTestBatchPreCommands>
<BashCLRTestPreCommands><![CDATA[
$(BashCLRTestPreCommands)
export COMPlus_ExpectedExitCode=64
]]></BashCLRTestPreCommands>
</PropertyGroup>
</Project>
10 changes: 10 additions & 0 deletions src/coreclr/tests/src/JIT/Methodical/xxobj/sizeof/_il_relsizeof_Target_32Bit.ilproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,14 @@
<ItemGroup>
<Compile Include="sizeof.il" />
</ItemGroup>
<PropertyGroup>
<CLRTestBatchPreCommands><![CDATA[
$(CLRTestBatchPreCommands)
set COMPlus_ExpectedExitCode=64
]]></CLRTestBatchPreCommands>
<BashCLRTestPreCommands><![CDATA[
$(BashCLRTestPreCommands)
export COMPlus_ExpectedExitCode=64
]]></BashCLRTestPreCommands>
</PropertyGroup>
</Project>