Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sizeof tests for arm and x86 #38577

Merged
merged 2 commits into from
Jun 30, 2020

Conversation

AndyAyersMS
Copy link
Member

On these tests the arm class layout happens to match the x64/arm64 layout and
is different than the x86 layout.

So, introduce arm specific test projects for these tests.

Also in the recent test build conversion one project was overlooked, so update
that project to work with this new scheme as well.

Closes #37470.

On these tests the arm class layout happens to match the x64/arm64 layout and
is different than the x86 layout.

So, introduce arm specific test projects for these tests.

Also in the recent test build conversion one project was overlooked, so update
that project to work with this new scheme as well.

Closes dotnet#37470.
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 29, 2020
@AndyAyersMS
Copy link
Member Author

cc @BruceForstall @jashook @sdmaclea

Git got carried away thinking there were some renames here so the diffs may look a bit clunky.

Will queue up outerloop tests shortly.

Copy link
Contributor

@sdmaclea sdmaclea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I would have probably chosen a a different name for the new arm projects. Probably either *Target_arm or *Target_64bit_or_arm (renaming the target_64bit test). I am OK with this approach though.

@AndyAyersMS
Copy link
Member Author

Two outerloop failures so far

Unable to precompile /__w/1/s/artifacts/tests/coreclr/Linux.arm64.Checked/Tests/Core_Root/Microsoft.CodeAnalysis.dll, exit code is 134.
Command-line: /__w/1/s/artifacts/bin/coreclr/Linux.arm64.Checked/x64/crossgen /Platform_Assemblies_Paths /__w/1/s/artifacts/tests/coreclr/Linux.arm64.Checked/Tests/Core_Root /__w/1/s/artifacts/tests/coreclr/Linux.arm64.Checked/Tests/Core_Root/Microsoft.CodeAnalysis.dll
Microsoft (R) CoreCLR Native Image Generator - Version 5.0.0-ci
Copyright (c) Microsoft Corporation.  All rights reserved.


Assert failure(PID 7396 [0x00001ce4], Thread: 7396 [0x1ce4]): Assertion failed 'kind == Overwrite' in 'Microsoft.Cci.MetadataWriter:PopulateMethodSemanticsTableRows():this' during 'Per block local var liveness' (IL size 578)

    File: /__w/1/s/src/coreclr/src/jit/jithashtable.h Line: 270
    Image: /__w/1/s/artifacts/bin/coreclr/Linux.arm64.Checked/x64/crossgen

Both look to be instances of #38496.

@AndyAyersMS
Copy link
Member Author

A number of arm/arm64 test legs passed and there's nothing mode specific about the re-enabled tests, so am going to ignore the failures and merge.

@AndyAyersMS AndyAyersMS merged commit 5bed9e7 into dotnet:master Jun 30, 2020
@AndyAyersMS AndyAyersMS deleted the FixSizeofTestsForArmAndX86 branch June 30, 2020 02:26
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure: JIT/Methodical/xxobj/sizeof/_il_dbgsizeof_Target_32Bit/_il_dbgsizeof_Target_32Bit.sh
4 participants