Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[debugger][wasm] Fix exception on _filter_automatic_properties #41614

Conversation

thaystg
Copy link
Member

@thaystg thaystg commented Aug 31, 2020

Fixing exception found while testing locally Blazor with .net 5.0.
I executed the StandaloneApp and put a breakpoint on counter++, when it breaks I tried to walk thought the stack and when I click on InvokeAsync from EventCallback.cs this exception was threw.

@ghost
Copy link

ghost commented Aug 31, 2020

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

@@ -386,6 +386,10 @@ var MonoSupportLib = {

for (var i in props) {
var p = props [i];

if (p.name == null)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a symptom of some other bug. Also, this function gets completely reworked in https://github.com/dotnet/runtime/pull/41480/files#diff-e04dc79ff3f1f7b84d42424ece6ba562 , which hopefully, will be merged soon. I can try to reproduce this issue on top of that PR.

@thaystg
Copy link
Member Author

thaystg commented Aug 31, 2020

As discussed on slack, @radical has a PR ready to fix it.

@thaystg thaystg closed this Aug 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants