Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[debugger][wasm] Fix exception on _filter_automatic_properties #41614

Closed
wants to merge 1 commit into from
Closed

[debugger][wasm] Fix exception on _filter_automatic_properties #41614

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/mono/wasm/runtime/library_mono.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,10 @@ var MonoSupportLib = {

for (var i in props) {
var p = props [i];

if (p.name == null)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a symptom of some other bug. Also, this function gets completely reworked in https://github.com/dotnet/runtime/pull/41480/files#diff-e04dc79ff3f1f7b84d42424ece6ba562 , which hopefully, will be merged soon. I can try to reproduce this issue on top of that PR.

continue;

if (p.name in names_found)
continue;

Expand Down