Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm][debugger] Add support for raising events in the app, intended to #42171

Merged
merged 2 commits into from
Sep 15, 2020

Conversation

radical
Copy link
Member

@radical radical commented Sep 13, 2020

.. be received by the debug proxy.

@radical
Copy link
Member Author

radical commented Sep 13, 2020

/cc @captainsafia

@jkotas
Copy link
Member

jkotas commented Sep 13, 2020

AllSubsets_Mono_RuntimeTests failure is #42172

@ghost
Copy link

ghost commented Sep 13, 2020

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

@radical radical added the arch-wasm WebAssembly architecture label Sep 14, 2020
@radical radical merged commit 6667d43 into dotnet:master Sep 15, 2020
@radical radical deleted the wasm-js-events branch September 15, 2020 18:04
@captainsafia
Copy link
Member

/backport to release/5.0-rc2

@github-actions
Copy link
Contributor

Started backporting to release/5.0-rc2: https://github.com/dotnet/runtime/actions/runs/259965228

@github-actions
Copy link
Contributor

@captainsafia backporting to release/5.0-rc2 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: [wasm][debugger] Add support for raising events in the app, intended to
error: sha1 information is lacking or useless (src/mono/wasm/runtime/library_mono.js).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 [wasm][debugger] Add support for raising events in the app, intended to
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@radical radical restored the wasm-js-events branch September 17, 2020 20:35
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants