Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLR JIT rolling build #42507

Merged
merged 1 commit into from
Sep 21, 2020

Conversation

BruceForstall
Copy link
Member

Build just the JIT, and upload the resulting JIT DLL to
CLR JIT Azure Storage.

This will be used as a baseline JIT for developer use, such
as assembly diffs.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 20, 2020
Build just the JIT, and upload the resulting JIT DLL to
CLR JIT Azure Storage.

This will be used as a baseline JIT for developer use, such
as assembly diffs.

Linux arm and Linux arm64 are disabled for now, until we can
determine how to properly configure Python on the build machines
with the azure-storage-blob package required for upload of the
JIT to Azure blob storage.
@BruceForstall
Copy link
Member Author

This change creates a JIT rolling build with the new "internal" pipeline "runtime-coreclr jitrollingbuild". Each built JIT is uploaded to the JIT Azure blob Storage location. Future changes will automatically download and use this when doing asm diffs.

@AndyAyersMS @kunalspathak @dotnet/jit-contrib PTAL

Copy link
Member

@AndyAyersMS AndyAyersMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of my comments on #42511 should have been made here, but it's just a nit.

@BruceForstall BruceForstall merged commit ab752c8 into dotnet:master Sep 21, 2020
@BruceForstall BruceForstall deleted the AddJitRollingBuild branch September 21, 2020 17:11
@BruceForstall
Copy link
Member Author

Follow-ups:

  1. Ensure there is some kind of automatic retention policy (i.e., files get automatically deleted after some period of time and/or some total size limit)
  2. Upload PDBs
  3. Build/upload cross-JITs (i.e., remove "-skipalljits" argument and make upload look for *clrjit*.[dll,dylib,so,pdb] in tree)

BruceForstall added a commit to BruceForstall/runtime that referenced this pull request Sep 21, 2020
Add `-base_git_hash` to allow specifying the exact baseline hash
to use.

Depends on JIT rolling build implemented in dotnet#42507

Allows running asm diffs with just:

    python superpmi.py asmdiffs
BruceForstall added a commit that referenced this pull request Sep 21, 2020
Add `-base_git_hash` to allow specifying the exact baseline hash to use.

Depends on JIT rolling build implemented in #42507

Allows running asm diffs with just:

    python superpmi.py asmdiffs
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants