Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete OutDir after zipping test folder in CI #43580

Closed
wants to merge 1 commit into from

Conversation

akoeplinger
Copy link
Member

We don't need it anymore and should help with the "no space left on device" issues during CI on e.g. the Browser wasm job.

We don't need it anymore and should help with the "no space left on device" issues during CI on e.g. the Browser wasm job.
@ghost
Copy link

ghost commented Oct 19, 2020

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is the right thing to do. This change breaks incremental builds as the obj (intermediate) and the bin (output) representation of the test project isn't in sync anymore. We might not required incremental builds in CI at the moment but I can't say if we might need them at some point.

Isn't there a better way to tackle the out-of-disk space issue? How large is the output directory on usually wasm test projects?

@akoeplinger
Copy link
Member Author

Since AzDO only gives us ~10GB of free space on the hosted pool we're running into the out of space issue there, the only other option is to use our own NetCorePublic pool which has plenty of disk space.

I think since we only do the OutDir deletion in the ArchiveTests step where we know we won't need it anymore afterwards I think that's fine for now.

@ViktorHofer
Copy link
Member

I think since we only do the OutDir deletion in the ArchiveTests step where we know we won't need it anymore afterwards I think that's fine for now.

The ArchiveTests target runs as part of the post-build per project which means that without a scheduler we don't know if the output directory is used by another test application.

Do you have data on how large the output directory is?

@akoeplinger
Copy link
Member Author

akoeplinger commented Oct 19, 2020

@ViktorHofer the output directory is about 50MB. I'll change over to the NetCorePublic pool then: #43589

@akoeplinger akoeplinger deleted the delete-outdir branch October 19, 2020 16:06
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants