Fix one reason for build failure when path contains spaces #44540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Assume the build (with space in path) succeeds after this change? |
|
No after the change the build fails due to an error in the auto-generated batch file for timestamp generation (also due to a space in the path) but that one is far harder to debug for someone without experience of the build system.
11 Nov 2020 19:49:31 Manish Godse <notifications@github.com>:
… Assume the build (with space in path) succeeds after this change?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub[#44540 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AATNTJBH5M7EZNOKU7RQS6TSPLMDPANCNFSM4TSKIFIQ]. [https://github.com/notifications/beacon/AATNTJARO5QA5G4XLPOMVFTSPLMDPA5CNFSM4TSKIFI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFM73WXY.gif]
|
|
oh ok. will take a look in the next few days. Is this blocking for you ? |
|
No. I moved the repository and stopped using |
|
I'm going to close this as the issue is fixed for @lkempf and if others hit it, we would ask them to help validate we have a complete fix. |
|
It also was one of our oldest active PRs |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.