[Android] Split android_security.c into multiple files #44603
Conversation
EgorBo
requested review from
akoeplinger,
marek-safar,
steveisok and
vargaz
as code owners
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @jeffhandley Issue meta data
|
| @@ -55,7 +55,7 @@ | |||
| <Exec Condition="'$(DeployAndRun)' == 'true'" Command="$(AdbTool) install $(ApkDir)/bin/HelloAndroid.apk" /> | |||
| <Exec Condition="'$(DeployAndRun)' == 'true' and '$(RunActivity)' != 'true'" Command="$(AdbTool) shell am instrument -w net.dot.HelloAndroid/net.dot.MonoRunner" /> | |||
| <Exec Condition="'$(DeployAndRun)' == 'true' and '$(RunActivity)' == 'true'" Command="$(AdbTool) shell am start -n net.dot.HelloAndroid/net.dot.MainActivity" /> | |||
| <Exec Condition="'$(DeployAndRun)' == 'true'" Command="$(AdbTool) logcat -d -s DOTNET" /> | |||
| <Exec Condition="'$(DeployAndRun)' == 'true'" Command="$(AdbTool) logcat -d" /> | |||
| </Target> | |||
There was a problem hiding this comment.
NOTE: -s DOTNET hides asserts and since we use samples as development playgrounds we don't need it.
| PALEXPORT int32_t CryptoNative_EvpDigestUpdate(jobject ctx, void* d, int32_t cnt); | ||
| PALEXPORT int32_t CryptoNative_EvpDigestFinalEx(jobject ctx, uint8_t* md, uint32_t* s); | ||
| PALEXPORT int32_t CryptoNative_EvpDigestCurrent(jobject ctx, uint8_t* md, uint32_t* s); | ||
| PALEXPORT void CryptoNative_EvpMdCtxDestroy(jobject ctx); |
There was a problem hiding this comment.
Unless there's a goal that the Android shim be able to be drop-in substituted for the OpenSSL shim (which feels like a hard state to maintain), the functions in this library should be named more appropriate to their context.
- CryptoNative is OK as long as this library and the OpenSSL shim can't ever be loaded in the same process, otherwise the exported function prefix for this library should be different (e.g. AndroidCryptoNative).
- Names like EvpDigestUpdate are because it's a thin wrapper over EVP_DigestUpdate. Since the Android implementation doesn't involve a function of that name the name should be more reflective of what is going on.
So I'd expect CryptoNative_EvpDigestUpdate to be AndroidCryptoNative_MessageDigestUpdate
There was a problem hiding this comment.
@bartonjs thats the plan, but I'd like to do it a bit later when it will be clear that we can replace openssl.
ghost
locked as resolved and limited conversation to collaborators
Following the OpenSSL and AppleTLS PAL conventions.
Aslo, I added
pal_bignumimplementation (based onjava.math.BigInteger) - it's needed for upcoming RSA impl (and other APIs).