Change FeedbackSize on Rijndael wrappers to delegate to implementation. #46686
Conversation
The FeedbackSize on RijndaelManaged and RijndaelImplementation were not accurately reflecting the feedback size that the actual implementation was using. The FeedbackSize would report 128, however the implementation defaults to 8, so CFB8 is actually what was being used. Likewise, the setter for FeedbackSize on the Rijndael types had no effect. The implementation's default feedback size of 8 would always be used.
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq Issue DetailsThe FeedbackSize on RijndaelManaged and RijndaelImplementation were not Likewise, the setter for FeedbackSize on the Rijndael types had no Contributes to #46672
|
|
@bartonjs This PR makes the "least breaking" change. If we were doing this before .NET 5 shipped, we'd also want to set It might be worth considering making this change anyway - the Rijndael types exist purely for compatibility reasons. It would seem strange that compatibility types are not... compatible. |
|
Yeah, let's go ahead and try it as the "NetFX compatible" version. |
We wanted to explicitly test the default FeedbackSize property without ever setting it.
|
@bartonjs Changed. |
|
I will eventually remember about Windows 7 / CFB stuff. Speaking of which @bartonjs, if you decide to backport this it should probably be done manually (which I am happy to do) to account for the CFB8 differences in .NET 5 vs. 6 in Windows 7. |
|
Failing mono test is addressed by #46699. |
Yeah, we probably should, just to try to limit the amount of damage (at least the workaround is easy, just assign the mode to CFB8).
Nice, much appreciated :) |
The FeedbackSize on RijndaelManaged and RijndaelImplementation were not
accurately reflecting the feedback size that the actual implementation
was using. The FeedbackSize would report 128, however the implementation
defaults to 8, so CFB8 is actually what was being used.
Likewise, the setter for FeedbackSize on the Rijndael types had no
effect. The implementation's default feedback size of 8 would always
be used.
Closes #46672