[release/5.0] cgroup: fix memory leak in GetCGroupMemoryUsage #49002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
changed the title
jkotas
approved these changes
Mar 2, 2021
jeffschwMSFT
approved these changes
Mar 2, 2021
mangod9
approved these changes
Mar 2, 2021
leecow
added
Servicing-approved
stephentoub
approved these changes
Mar 3, 2021
|
known crypto failures |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #48822
Fix in main: #48911
Customer Impact
The memory usage of the application increases linearly over time (memory leak) when running on a system with cgroup enabled. Reported by customer (@gerlachch).
Testing
Add hoc testing. We do not have test infrastructure that would catch this bug currently.
Risk
Low. Very straightforward change.
Regression
Regression in .NET 5. Introduced by adding support for cgroup2 (#34334).